Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FasterXML/jackson-databind#1296 @JsonIncludeProperties #2771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FasterXML/jackson-databind#1296 @JsonIncludeProperties #2771
Changes from all commits
0b3e175
2186fbe
4191171
8e8671f
07e6bde
35c1f60
a3db197
d575e31
92decd8
5a89ec6
b740511
19a764d
7603c59
f1d122d
602ecd9
fbf4c12
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(note to self, mostly)
Makes sense to use different name, I think,
withPropertyInclusions()
(to indicate both ignoral and/or inclusion contained), for the new method.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not 100% sure if this is the right default: seems like there would be 3 possibilities:
Now, adding "mode" or something in
JsonIncludeProperties
(and.Value
) would allow specifying these modes easily if we want to. But even without adding that, I wonder what the most likely expected use case would be?My guess would have been either (3) or (2).