added SET_PROPERTY_CREATOR_AS_DEFAULT MapperFeature#1634
added SET_PROPERTY_CREATOR_AS_DEFAULT MapperFeature#1634cowtowncoder merged 2 commits intoFasterXML:masterfrom lpandzic:#1631
Conversation
|
I'm sorry but I don't think this makes sense. This would enable auto-detection of all constructors, without annotation. |
|
Only for those for which creator data is created. This solves the issue of not providing @JsonCreator when using parameter names module and since it's disabled by default, there's no bc issue. |
| */ | ||
| INFER_CREATOR_FROM_CONSTRUCTOR_PROPERTIES(true), | ||
|
|
||
| SET_PROPERTY_CREATOR_AS_DEFAULT(false), |
There was a problem hiding this comment.
Need javadoc, including both explanation and since 2.9 indicator.
|
Ah. Ok. So only gets called if "creator-ness" is first decided. Makes sense. I think it'd be good to have a test case in |
|
I agree that there should be a test, but I'm not sure what use case to cover without ParameterNamesModule. Constructor with JsonProperty parameters and without JsonCreator won't work. |
|
@lpandzic Right, a unit test could work. There are couple of tests that implement mock |
Fixes #1631.
The tests for this are in the parameter names module.