Skip to content

Commit c12366e

Browse files
committed
Merge branch '2.7' into 2.8
2 parents 407f10e + bba3620 commit c12366e

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

release-notes/VERSION

+1
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ Project: jackson-databind
3737
(reported by Jörn H)
3838
#1432: Off by 1 bug in PropertyValueBuffer
3939
(reported by Kevin D)
40+
#1439: NPE when using with filter id, serializing `java.util.Map` types
4041

4142
2.8.3 (17-Sep-2016)
4243

src/main/java/com/fasterxml/jackson/databind/ser/std/MapSerializer.java

+6-6
Original file line numberDiff line numberDiff line change
@@ -525,9 +525,9 @@ public void serialize(Map<?,?> value, JsonGenerator gen, SerializerProvider prov
525525
if (_sortKeys || provider.isEnabled(SerializationFeature.ORDER_MAP_ENTRIES_BY_KEYS)) {
526526
value = _orderEntries(value, gen, provider, suppressableValue);
527527
}
528-
if (_filterId != null) {
529-
serializeFilteredFields(value, gen, provider,
530-
findPropertyFilter(provider, _filterId, value), suppressableValue);
528+
PropertyFilter pf;
529+
if ((_filterId != null) && (pf = findPropertyFilter(provider, _filterId, value)) != null) {
530+
serializeFilteredFields(value, gen, provider, pf, suppressableValue);
531531
} else if (suppressableValue != null) {
532532
serializeOptionalFields(value, gen, provider, suppressableValue);
533533
} else if (_valueSerializer != null) {
@@ -559,9 +559,9 @@ public void serializeWithType(Map<?,?> value, JsonGenerator gen, SerializerProvi
559559
if (_sortKeys || provider.isEnabled(SerializationFeature.ORDER_MAP_ENTRIES_BY_KEYS)) {
560560
value = _orderEntries(value, gen, provider, suppressableValue);
561561
}
562-
if (_filterId != null) {
563-
serializeFilteredFields(value, gen, provider,
564-
findPropertyFilter(provider, _filterId, value), suppressableValue);
562+
PropertyFilter pf;
563+
if ((_filterId != null) && (pf = findPropertyFilter(provider, _filterId, value)) != null) {
564+
serializeFilteredFields(value, gen, provider, pf, suppressableValue);
565565
} else if (suppressableValue != null) {
566566
serializeOptionalFields(value, gen, provider, suppressableValue);
567567
} else if (_valueSerializer != null) {

0 commit comments

Comments
 (0)