Skip to content

Commit bba3620

Browse files
committed
Fix #1439
1 parent 409cb7c commit bba3620

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

release-notes/VERSION

+1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ Project: jackson-databind
1212
(reported by Jörn H)
1313
#1432: Off by 1 bug in PropertyValueBuffer
1414
(reported by Kevin D)
15+
#1439: NPE when using with filter id, serializing `java.util.Map` types
1516

1617
2.7.8 (26-Sep-2016)
1718

src/main/java/com/fasterxml/jackson/databind/ser/std/MapSerializer.java

+6-6
Original file line numberDiff line numberDiff line change
@@ -508,9 +508,9 @@ public void serialize(Map<?,?> value, JsonGenerator gen, SerializerProvider prov
508508
if (_sortKeys || provider.isEnabled(SerializationFeature.ORDER_MAP_ENTRIES_BY_KEYS)) {
509509
value = _orderEntries(value);
510510
}
511-
if (_filterId != null) {
512-
serializeFilteredFields(value, gen, provider,
513-
findPropertyFilter(provider, _filterId, value), suppressableValue);
511+
PropertyFilter pf;
512+
if ((_filterId != null) && (pf = findPropertyFilter(provider, _filterId, value)) != null) {
513+
serializeFilteredFields(value, gen, provider, pf, suppressableValue);
514514
} else if (suppressableValue != null) {
515515
serializeOptionalFields(value, gen, provider, suppressableValue);
516516
} else if (_valueSerializer != null) {
@@ -542,9 +542,9 @@ public void serializeWithType(Map<?,?> value, JsonGenerator gen, SerializerProvi
542542
if (_sortKeys || provider.isEnabled(SerializationFeature.ORDER_MAP_ENTRIES_BY_KEYS)) {
543543
value = _orderEntries(value);
544544
}
545-
if (_filterId != null) {
546-
serializeFilteredFields(value, gen, provider,
547-
findPropertyFilter(provider, _filterId, value), suppressableValue);
545+
PropertyFilter pf;
546+
if ((_filterId != null) && (pf = findPropertyFilter(provider, _filterId, value)) != null) {
547+
serializeFilteredFields(value, gen, provider, pf, suppressableValue);
548548
} else if (suppressableValue != null) {
549549
serializeOptionalFields(value, gen, provider, suppressableValue);
550550
} else if (_valueSerializer != null) {

0 commit comments

Comments
 (0)