go back to using switch statements in schubfach code #853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cowtowncoder
approved these changes
Dec 1, 2022
|
@cowtowncoder would it be worthwhile copying the Since the code is not the default mode and the tests haven't changed (except that you reduced the iterations count to speed up the tests) - it seems pretty low risk. |
|
@pjfanning yes, +1 for that if you have time? I agree, sounds like low risk to me (not minimal but low enough). |
|
@cowtowncoder I added #854 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I ported over #852, I had compile warnings about some switch statements. I rewrote them using if statements.
In hindsight, I should have looked more closely - the warnings were about some specific features, the switch statements themselves are ok.