Skip to content

Add JsonParser feature to ignore a trailing comma (fixes #118, #323) #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2016

Conversation

bdhess
Copy link
Contributor

@bdhess bdhess commented Oct 29, 2016

Design discussion in #323

Diff of the before/after benchmark results:
bdhess/jackson-benchmark-logs@590fa18?diff=split

@cowtowncoder
Copy link
Member

@bdhess I think this is pretty good; I may make some minor changes but nothing major. Thank you for doing benchmarks too; from quick glance numbers looked quite similar. I can also run tests locally myself to double-check, but from changes I think we should be good.

So: I'd be happy to merge this PR to be included in master for 2.9.

One last thing however: before merging the first contribution, we need CLA (unless I already asked and got one; I tried to verify). It's here:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and the usual way is to print, fill & sign, scan/take photo, email to info at fasterxml dot com.
Once we get this, I'll go ahead and merge this.

Looking forward to merging!

@cowtowncoder cowtowncoder merged commit ad6d3cc into FasterXML:master Nov 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants