-
-
Notifications
You must be signed in to change notification settings - Fork 812
Skip RS CTRL-CHAR to support JSON Text Sequence (RFC7464) #1414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Fawzi Essam <[email protected]>
Signed-off-by: Fawzi Essam <[email protected]>
Signed-off-by: Fawzi Essam <[email protected]>
Signed-off-by: Fawzi Essam <[email protected]>
Signed-off-by: Fawzi Essam <[email protected]>
Signed-off-by: Fawzi Essam <[email protected]>
src/main/java/com/fasterxml/jackson/core/base/ParserMinimalBase.java
Outdated
Show resolved
Hide resolved
src/main/java/com/fasterxml/jackson/core/json/JsonReadFeature.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Fawzi Essam <[email protected]>
Signed-off-by: Fawzi Essam <[email protected]>
@@ -193,6 +193,12 @@ public enum Feature { | |||
@Deprecated | |||
ALLOW_UNQUOTED_CONTROL_CHARS(false), | |||
|
|||
/** | |||
* @deprecated Use {@link com.fasterxml.jackson.core.json.JsonReadFeature#ALLOW_RS_CONTROL_CHAR} instead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May look funny but JsonParser.Feature
is to be removed from 3.0 yet is needed internally (all StreamReadFeature
s and JsonReadFeature
s must map back to one entry).
But we don't want users to use JsonParser.Feature
any more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good to know about that to help take care of it next time.
Thanks for your collaboration on the PRs!
@iifawzi Implementation looks good; refactored things slightly wrt tests but functionally it was fine. The only concern I have is merging to 3.0/master -- that will be some fun. But I'll take care of it. Thank you again for contributing this! EDIT: merging wasn't too bad after all. :) |
Thanks for your collaboration @cowtowncoder, it helps and encourages contributing to the project. |
@iifawzi thank you! It is great to hear that! And thank you for your contributions so far. On RS in content: unless there's strong use case for allowing it (that is, some actually needing it for specific use), I'd probably not want to add support for in-content. #1144 would be good to try to figure out. |
Hello, This PR tries to resolve #633
This is my first PR for the project, so I could be missing a point. Feel free to guide me through points that might need to be added.
I didn't implement it in the data input parser as it seems like we're skipping the validation of WS
jackson-core/src/main/java/com/fasterxml/jackson/core/json/UTF8DataInputJsonParser.java
Lines 2299 to 2304 in 99f749d
so not sure if we need to have it now, the same way we do for other parsers