Fix #1328: optimize JsonPointer.head()
#1354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjfanning
reviewed
Apr 27, 2025
| while (current != last) { | ||
| JsonPointer nextSegment = new JsonPointer(current, | ||
| fullString, offset); | ||
| offset += suffixLength; |
There was a problem hiding this comment.
@cowtowncoder This code adds the suffix Len to the prefix/offset Len. I think this is the cause of #1425.
There was a problem hiding this comment.
Yes, exactly. Not sure why I chose that, makes no sense.
I am trying to remember if this is the one case where I did ask ChatGPT help with recursion or not (it was for something within this class). If so would be hilarious fail on my part.
At any rate, fixed via #1426 -- code is bit tricky to reason about but I think it works better now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.