TokenStreamFactory.createNonBlockingByteBufferParser() return type wrong #1527
Description
Both createNonBlockingByteArrayParser() and createNonBlockingByteBufferParser() in TokenStreamFactory have the same type bound for the return type:
P extends JsonParser & ByteArrayFeeder
I'd expect the type for createNonBlockingByteBufferParser() to be
P extends JsonParser & ByteBufferFeeder.
Is this a copy-paste error or am I missing something?
Activity
pjfanning commentedon Dec 12, 2025
@hb16 the method signature is wrong - can you use JsonFactory for now? JsonFactory has the method and you can cast its return type to ByteBufferFeeder. We will try to fix the return types in an upcoming release.
cowtowncoder commentedon Dec 12, 2025
Definitely copy-paste fail. Embarrassing.
[-]createNonBlockingByteBufferParser() return type[/-][+]`TokenStreamFactoy.createNonBlockingByteBufferParser()` return type wrong[/+][-]`TokenStreamFactoy.createNonBlockingByteBufferParser()` return type wrong[/-][+]`TokenStreamFactory.createNonBlockingByteBufferParser()` return type wrong[/+]cowtowncoder commentedon Dec 12, 2025
Fixed by #1528
pjfanning commentedon Dec 12, 2025
You'd really have expected that the Java parser would have prevented this.
cowtowncoder commentedon Dec 12, 2025
@pjfanning I think part of the problem was override in
JsonFactorythat used too generic return type, instead of indicating mismatch withTokenStreamFactorybase typing.