Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add view limit level parameter when show skeleton #31

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

TaQuangTu
Copy link

@TaQuangTu TaQuangTu commented Feb 22, 2021

I see that showing skeleton for all leaf views (views at the bottom of the view tree and have no children) is not always give a good look. I have added a field named limitToLevel: Int (default = MAX_INT) to limit the depth at which child views in the SkeletonLayout should show skeleton and stop traveling down to their child views to show skeleton. This change does not require coders to modify their code except when they need to use the parameter. I hope you will consider my tiny effort. Thank you!

@Faltenreich
Copy link
Owner

Thanks for your PR and sorry for the late response! Is this feature still required and if so, could you explain one simple use case, so that I am able to understand the requirements? Thanks in advanca and all the best!

@Faltenreich Faltenreich added the question Further information is requested label Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants