Improved contributor modal hash and support for new authors #153
Conversation
TheRolfFR
force-pushed
the
fix/contributor_modal_names_duplicated
branch
from
6286dc0 to
c7a281b
Compare
| const notAlreadyAuthorsIds = authorIds.filter((id) => alreadyAuthorsIds.indexOf(id) === -1); | ||
| const searchIDsparam = notAlreadyAuthorsIds.join(',') | ||
| const notAlreadyAuthorsFound = (!searchIDsparam) ? [] : | ||
| await axios.get(`${this.$root.apiURL}/users/${searchIDsparam}`) |
There was a problem hiding this comment.
isn't contributors already cached? why do we need to re-fetch everything?
There was a problem hiding this comment.
future new authors aren't, user select fetches them online but forgets to emit it to form and modal
There was a problem hiding this comment.
I feel like it would be smarter to fetch every user when the component is created then filter relevant results using a computed property
There was a problem hiding this comment.
I think it would make more sense to fetch every user when the component is created (using https://api.faithfulpack.net/v2/users/names), then filter relevant results using a computed property—that way you avoid the request overhead/api spam and you still have fast contribution adding using the user-select component
oh also please run prettier on your code before merging (nicer diff)
| @@ -65,6 +65,7 @@ | |||
| :error-messages=" | |||
| content.length === 0 ? [$root.lang('database.subtitles.no_contributor_yet')] : [] | |||
| " | |||
| @newUsers="(l) => this.$emit('newUser', l) " | |||
There was a problem hiding this comment.
this should be @newUser according to the user-select code I think
| @@ -50,7 +50,7 @@ | |||
| <v-list-item-title>{{ panelLabels[form.formId] }}</v-list-item-title> | |||
| <v-list-item-subtitle class="text-truncate"> | |||
| <span v-if="form.authors.length"> | |||
| {{ contributorsFromIds(form.authors) }} | |||
| {{ formAuthorNames[form.formId] || '...' }} | |||
There was a problem hiding this comment.
use "…" instead of "...", bit nicer
| const notAlreadyAuthorsIds = authorIds.filter((id) => alreadyAuthorsIds.indexOf(id) === -1); | ||
| const searchIDsparam = notAlreadyAuthorsIds.join(',') | ||
| const notAlreadyAuthorsFound = (!searchIDsparam) ? [] : | ||
| await axios.get(`${this.$root.apiURL}/users/${searchIDsparam}`) |
There was a problem hiding this comment.
I feel like it would be smarter to fetch every user when the component is created then filter relevant results using a computed property
Fixes #122 with better hash and added support for new authors in contributor modal