Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow playing on 1.21.0 #155

Conversation

MerchantPug
Copy link

It shouldn't hurt to do this.

If you're a player, I'm sorry that you're stuck on this version.

If you're a modder who has done what the branch's title is, update your damn mod version!
~1.21 is good enough even, it's better to error on future MC versions instead of what's a patch version.

@MerchantPug
Copy link
Author

MerchantPug commented Dec 6, 2024

Porting Lib devs, feel free to reject. I understand if y'all don't want this. I wouldn't want to support what's basically a version of the game that has a really bad exploit either.

@IThundxr
Copy link
Member

IThundxr commented Dec 6, 2024

I don't really have a problem with this being merged, but what needs to be made sure is that fabric API for 1.21.1 has the same type of dependency

@MerchantPug
Copy link
Author

I don't really care much, but what needs to be made sure is that fabric API for 1.21.1 has the same type of dependency

Mhm, we might need to test it a bit to make sure that everything works on the latest 1.21.0 FAPI.

@MerchantPug
Copy link
Author

I don't really have a problem with this being merged, but what needs to be made sure is that fabric API for 1.21.1 has the same type of dependency

It does. I don't think they did anything outside of new api changes.

@TropheusJ
Copy link
Member

1.21.0 is one of the versions that it’s not possible to be stuck on. Doing this only adds another version to support for no reason

@TropheusJ TropheusJ closed this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants