Conversation
|
@l-kotzur I really like this. But i think we need to regenerate the golde test files for this to pass ci. But i fully understand if you want to merge this before of course :) |
|
@l-kotzur, thank you very much for looking into this. I hope I can review and merge it by the end of the week. |
|
Thanks, I have no hurries. Do the #234 first. Then we can remove the golde test and discuss performance. |
|
@l-kotzur just to make sure:
Option 1 should be prefered if the differences are as small as in this case, and if its an actual bug... Option 2 adds complexity and should only be chosen for good reasons |
Description
In rare cases tsam violates the original lower or upper bounds of the time series leading to a UserWarning: At least one maximal value of the aggregated time series exceeds the maximal value the input time series for: ...
Motivation and Context
This fixes the scaling and the min max distribution representation.
Type of Change
Checklist
ruff checkandruff format)pytest test/)