Skip to content

Feature/private methods#142

Draft
FBumann wants to merge 2 commits intoFZJ-IEK3-VSA:developfrom
FBumann:feature/private-methods
Draft

Feature/private methods#142
FBumann wants to merge 2 commits intoFZJ-IEK3-VSA:developfrom
FBumann:feature/private-methods

Conversation

@FBumann
Copy link
Copy Markdown
Collaborator

@FBumann FBumann commented Feb 3, 2026

Description

Make some internaly usd methods private to reduce the namespace. Mostly cosmetic

Motivation and Context

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • My code follows the project's code style (run ruff check and ruff format)
  • I have added tests that prove my fix/feature works
  • All new and existing tests pass (pytest test/)
  • I have updated the documentation if needed

@FBumann FBumann marked this pull request as ready for review February 3, 2026 14:43
@julian-belina
Copy link
Copy Markdown
Collaborator

Should this also be integrated into version 3.1.0, @FBumann?

@FBumann
Copy link
Copy Markdown
Collaborator Author

FBumann commented Feb 3, 2026

Should this also be integrated into version 3.1.0, @FBumann?

I dont care to be honest.
For me its fine to do this in the upcoming weeks. Its just a patch. We can also leave them public.

@FBumann FBumann marked this pull request as draft February 20, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants