lib: Support epoll APIs in thread management lib #19917
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
oops - I see this is getting flagged because the original code used deprecated hash apis - I'll push a fix |
donaldsharp
reviewed
Nov 2, 2025
donaldsharp
reviewed
Nov 2, 2025
mjstapp
changed the title
Contributor
Author
|
whoops - missed a checkpatch error, pushed a fix; still working on replacing the deprecated hash code |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Contributor
Author
|
converted hash to typesafe apis, and rebased to newer master |
Contributor
Author
|
CI:rerun |
Contributor
Author
|
let's run again, see where we are |
Contributor
Author
|
I've temporarily made epoll the default (where available) so we can do test runs. I've added the "do not merge" tag temporarily too. |
Contributor
Author
|
CI:rerun |
This commit adds support for epoll APIs for better performance. This is controlled by a configure option. Note that epoll APIs are only available for Linux platforms. For BSD and other linux platforms which do not support epoll APIs, poll APIs are still used. Signed-off-by: Kaifei Peng <[email protected]> Signed-off-by: Mark Stapp <[email protected]>
Contributor
Author
|
Pushed a couple of updates to stop emitted warning/debug messages in some cases |
added 2 commits
November 7, 2025 15:49
Use the typesafe hash lib for the new epoll objects. Also make a few cleanups and adjustments after testing. Signed-off-by: Mark Stapp <[email protected]>
Enable epoll by default, temporarily for testing Signed-off-by: Mark Stapp <[email protected]>
Contributor
Author
|
pushed an update to handle cancel of closed fds more cleanly, and to use jhash for the epoll fds that we hash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit substitutes poll APIs with epoll APIs for better performance. Note that epoll APIs are only available for Linux platforms. For BSD and other linux platforms which do not support epoll APIs, poll APIs are still used.
This is a rebase/update of #18126 , which was itself an update of the original PR #12862 . We're going to try to get this work moving forward again.