bgpd: Move mpath pointer from bgp_path_info to bgp_dest #19880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimize BGP memory usage by relocating the multipath (mpath) pointer from bgp_path_info to bgp_dest. In ECMP scenarios, the number of bgp_path_info entries can be up to MULTIPATH_NUM times that of bgp_dest. By moving the mpath pointer to bgp_dest, we reduce the total number of mpath pointers allocated, leading to lower memory consumption in large BGP deployments. Signed-off-by: Yuqing Zhao <[email protected]>
ton31337
reviewed
Oct 29, 2025
|
So every bgp_dest allocated grows by 8 bytes. While For each path_info received the path_info will shrink by 8 bytes.. With any type of ECMP the savings should be significant for v4 and v6. |
|
Yes, that's clear, but interesting if some testings were made at scale. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change optimizes BGP memory usage
by relocating the multipath (mpath) pointer from bgp_path_info to bgp_dest.
In ECMP scenarios, the number of bgp_path_info entries can be up to MULTIPATH_NUM times that of bgp_dest.
By moving the mpath pointer to bgp_dest, we reduce the total number of mpath pointers allocated,
leading to lower memory consumption in large BGP deployments.