redhat: fixup rpm generation #19849
Open
redhat: fixup rpm generation #19849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
louberger
commented
Oct 27, 2025
louberger
commented
use py3.6 when building docs (3.12 failed)
remove protobuf-c-devel requirement except when building grpc
conditionally include conditionally built library
Signed-off-by: Lou Berger <[email protected]>
rjarry
reviewed
Oct 28, 2025
Comment on lines
+78
to
+82
| # force python 3.6 for sphinx | ||
| %if %{with_docs} | ||
| %global python3_pkgversion 3.6 | ||
| %global __python3 /usr/bin/python3.6 | ||
| %endif |
There was a problem hiding this comment.
That seems a bit fragile. It will depend on which distro the upstream RPM is generated. If it is Centos-Stream 9, then the default python is 3.9.
| BuildRequires: gcc | ||
| BuildRequires: json-c-devel | ||
| BuildRequires: libcap-devel | ||
| BuildRequires: protobuf-c-devel |
There was a problem hiding this comment.
You are not adding it back when grpc is enabled?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.