Revert "tools: Ignore errors for frr reload stuff" #19780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 243e27a. It needs to be very strict, otherwise, all the commands that return `CMD_WARNING_CONFIG_FAILED` (and other errors) will be imperceptibly ommitted, seriously affecting the functionality. Signed-off-by: anlan_cs <[email protected]>
Member
|
IMO, it's reverse. Restarting the service on a wrong command is not what I should expect as an operator, TBH. |
Contributor
Author
Without this revert, the caller need check all these errors (including failed, and others) themself, it is impossible. |
Member
|
We've gone back and forth multiple times on this. What is the correct behavior that we want here? I don't want to keep going back and forth over and over. Do we need a new/different approach to the whole problem? |
Contributor
Author
|
The initial design is correct: @donaldsharp @ton31337
So, to fix PR 13888, the caller need add check to ensure all commands are known. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 243e27a.
It needs to be very strict, otherwise, all the commands that return
CMD_WARNING_CONFIG_FAILED(and other errors) will be imperceptibly ommitted, seriously affecting the functionality.