Skip to content

Conversation

@mqy9811
Copy link

@mqy9811 mqy9811 commented Sep 26, 2025

1、Adjust Function set_metric and update the functions that call it.
2、Correct the metric setting in Function ospf_handle_summarylsa_lsId_chg, which was truncated due to data size issues.

@riw777
Copy link
Member

riw777 commented Sep 30, 2025

Can you look at the style guidelines and make certain this code is within them? I see there is a "signed off by" line missing, so I'm assuming there are other issues here ... thanks!

@mqy9811
Copy link
Author

mqy9811 commented Sep 30, 2025

Can you look at the style guidelines and make certain this code is within them? I see there is a "signed off by" line missing, so I'm assuming there are other issues here ... thanks!

I'm terribly sorry. This is my first submission here, and I overlooked the rules.

    Fix the issue where the OSPF Summary LSA's metric value fails to update properly and promptly when the LinkID changes.

    1、Adjust Function set_metric and update the functions that call it.
    2、Correct the metric setting in Function ospf_handle_summarylsa_lsId_chg, which was truncated due to data size issues.

    Configuration topology: Single routing device. Configuration content: Configure the OSPF protocol, add Area 0 and Area 1 respectively, and assign valid interfaces to the two areas. In Area 1, configure command A and set the metric value to 100. Check the OSPF database to confirm the generation of Summary LSAs correctly .

    Signed-off-by: “qlmeng” <[email protected]>
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good ... do we need a topo test to catch this in the future?

@riw777
Copy link
Member

riw777 commented Nov 4, 2025

looks like sanitizer thinks there's a new memory leak here:

<body>
<!--StartFragment-->
28-Oct-2025 12:59:25 | Address Sanitizer Error detected in bgp_flowspec.test_bgp_flowspec_topo/r1.asan.bgpd.6397
-- | --
28-Oct-2025 12:59:25 | ASAN Leak Detector:
28-Oct-2025 12:59:25 | New Leaks detected:  1

<!--EndFragment-->
</body>
</html>```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants