-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add speaker info to xml export #267
base: master
Are you sure you want to change the base?
Conversation
I would like to also add the speaker photo, but I see it's a bit more complicated by looking at I think speaker photo is not critical and can be complicated (considering resizing, etc.), so I can propose a separate PR for it. |
I'm planning a change to the URL's generated for attachments and speaker images. It may simplify things so I would wait for that. |
you should still add the id or slug to the speakers per talk (similar to my pr) otherwise you can not link both together. |
You are right, I'll look into this ASAP. |
@johanvdw Actually, there's already |
@johanvdw Could you confirm that you still want me to change this PR? |
Is there any chance to merge this PR? (I might be still able to integrate speaker bios in my app) |
Adds speaker slug, biography and other info to the xml export in a new
persons
section.Alternative to #266