Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slug to speakers xml export (proposal) #266

Closed
wants to merge 1 commit into from
Closed

Add slug to speakers xml export (proposal) #266

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion content/schedule/pentabarf.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ xml.schedule do
xml.feedback_url event[:feedback_url]
xml.persons do
event[:speakers].map(&$to_speaker).each do |speaker|
xml.person( speaker[:name], {:id=>speaker[:person_id]} )
xml.person( speaker[:name], {:id=>speaker[:person_id],:slug=>speaker[:slug]} )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add:

:avatar=>speaker[:avatar],:biography=>speaker[:biography]

(only based on documentation, I haven't tested it, can do it later this week)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that is the right solution, because it would duplicate biographies for speakers. Moreover, I would not store the biography as an attribute.

Perhaps we could add a section. xxxyyyy, so both can be linked?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you are right, although I am not sure how big of a problem duplicates are. Probably the change would need to be backwards-compatible, so speaker name can stay and a new section by person_id or code (I can look into this on the weekend).

end
end
xml.attachments do
Expand Down