Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added elements to remove some hardcoded primaryKey field name #19

Open
wants to merge 1 commit into
base: stable
Choose a base branch
from

Conversation

tranfuga25s
Copy link

This pull request helps in the situations where the ACO object's do not have "id" has primaryKey field.
See issue #18

@FMCorz
Copy link
Owner

FMCorz commented Sep 24, 2014

Thanks for the pull request.

1/ Could you clean your patch not to fix all those whitespace issues? Ideally this should take place in another pull request as it could create unnecessary conflicts with other patches, and is not the right place to fix it.

2/ You are adding another $inherit = in the view rather than fixing the existing one.

3/ Indentation issue when setting aroPk to the view.

Many thanks!
Fred

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants