CoefficientSplitter: fix again ReferenceGrad(Zero)#460
Merged
mscroggs merged 1 commit intoFEniCS:mainfrom Jan 9, 2026
Merged
Conversation
fcd9891 to
b5e77a4
Compare
mscroggs
approved these changes
Jan 9, 2026
pbrubeck
added a commit
to firedrakeproject/ufl
that referenced
this pull request
Jan 9, 2026
jhale
pushed a commit
that referenced
this pull request
Jan 13, 2026
* Fix split for symmetric tensors (#448) * BUG: prevent ReferenceGradient(Zero) on CoefficientSplitter (#455) * BUG: prevent ReferenceGradient(Zero) on CoefficientSplitter * test * fix for mixed dimension cells * cleanup * Pullback: remove FunctionSpace (#452) * Pullback: remove FunctionSpace * cast to int * import Zero * CoefficientSplitter: fix again ReferenceGrad(Zero) (#460)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first fix didn't take into account elements where the reference value shape differs from the physical value shape.