Open
Conversation
Remove no longer necessary `type: ignore`'s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the runtime generated class hierarchy in favour of explicitly inheriting form
UFLType. All information is propagated through the class hierarchy inheriting fromUFLTypeand thus follows standard Python rules. This removes the need for 'checking the type system' and opens the expression hierarchy up for further changes and upgrades.The decorator
ufl_typenow only sets the properties_ufl_typecode_and_ufl_handler_name_, but no more of other 'traits'. These two options are somewhat special and are required to exist prior to anyUFLTypeinstantiation (so__new__is not usable for those). This should probably be addressed at a later stage to remove the@ufl_typecompletely.Global class tracking and profiling information is moved from the
UFLTypebase class to the newUFLRegistry, which for now maintains both (classes and profiling). This can also be further refined in the future.First (big) step to resolving #127: Introduces a test case showcasing how external types now fit into the UFL abstractions and can be handled with the same transformations.