Skip to content

Pass correct cell/facet index in tabulate_expression #4103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michalhabera wants to merge 5 commits into
base: main
Choose a base branch
from
+4 −1
Open

Pass correct cell/facet index in tabulate_expression #4103

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bc0ad44
Pass cell/facet index
michalhabera Feb 24, 2026
42fa82b
Merge branch 'main' into michal/bugfix-expression-permutation
jhale Feb 28, 2026
023e8ef
Merge branch 'main' into michal/bugfix-expression-permutation
garth-wells Feb 28, 2026
43caf2b
Merge branch 'main' into michal/bugfix-expression-permutation
michalhabera Mar 11, 2026
52b6efe
Apply suggestion
michalhabera Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cpp/dolfinx/fem/assemble_expression_impl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,10 @@ void tabulate_expression(
coord_dofs.data(), &entities(e, 1), nullptr, nullptr);
}

P0(values_local, cell_info, e, size0);
if constexpr (entities.rank() == 1)
P0(values_local, cell_info, entities(e), size0);
else
P0(values_local, cell_info, entities(e, 0), size0);
for (std::size_t j = 0; j < values_local.size(); ++j)
values[e * offset + j] = values_local[j];
}
Expand Down
Loading