Skip to content

Pass custom_data through assemblers to kernel functions. #4013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sclaus2 wants to merge 14 commits into
base: main
Choose a base branch
from
+597 −62

Merge branch 'main' into sclaus2/pass_custom_data_to_assembler

0f7d14b
Select commit
Loading
Failed to load commit list.
Open

Pass custom_data through assemblers to kernel functions. #4013

Merge branch 'main' into sclaus2/pass_custom_data_to_assembler
0f7d14b
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Dec 11, 2025 in 4m 57s

Quality Gate passed

Issues
24 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.5% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 60 in python/test/unit/fem/test_custom_data.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this parameter "A_" to match the regular expression ^[_a-z][a-z0-9_]*$. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZraT3PMqA6mqPYJkcJ9&open=AZraT3PMqA6mqPYJkcJ9&pullRequest=4013

Check warning on line 233 in python/test/unit/fem/test_custom_data.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable "Ae" to match the regular expression ^[_a-z][a-z0-9_]*$. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZraT3PMqA6mqPYJkcKA&open=AZraT3PMqA6mqPYJkcKA&pullRequest=4013

Check failure on line 35 in cpp/dolfinx/fem/assemble_scalar_impl.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "void *" with a more meaningful type. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZrb3q_eu-mtKnwcCd-f&open=AZrb3q_eu-mtKnwcCd-f&pullRequest=4013

Check failure on line 887 in cpp/dolfinx/fem/assemble_vector_impl.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "void *" with a more meaningful type. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZraT3OIqA6mqPYJkcJ7&open=AZraT3OIqA6mqPYJkcJ7&pullRequest=4013

Check warning on line 27 in cpp/dolfinx/fem/assemble_scalar_impl.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 8 parameters, which is greater than the 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZraT3LpqA6mqPYJkcJs&open=AZraT3LpqA6mqPYJkcJs&pullRequest=4013

Check failure on line 98 in cpp/dolfinx/fem/assemble_vector_impl.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "void *" with a more meaningful type. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZraT3OIqA6mqPYJkcJ2&open=AZraT3OIqA6mqPYJkcJ2&pullRequest=4013

Check warning on line 411 in python/test/unit/fem/test_custom_data.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZrmBE5vLeH4FS8Q4kue&open=AZrmBE5vLeH4FS8Q4kue&pullRequest=4013

Check warning on line 73 in python/test/unit/fem/test_custom_data.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable "Ae" to match the regular expression ^[_a-z][a-z0-9_]*$. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZraT3PMqA6mqPYJkcJ-&open=AZraT3PMqA6mqPYJkcJ-&pullRequest=4013

Check failure on line 686 in cpp/dolfinx/fem/assemble_vector_impl.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "void *" with a more meaningful type. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZrb4ah-c6ZwUjXdScc0&open=AZrb4ah-c6ZwUjXdScc0&pullRequest=4013

Check warning on line 312 in python/test/unit/fem/test_custom_data.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable "Ae" to match the regular expression ^[_a-z][a-z0-9_]*$. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZrmBE5vLeH4FS8Q4kuc&open=AZrmBE5vLeH4FS8Q4kuc&pullRequest=4013

Check warning on line 376 in python/test/unit/fem/test_custom_data.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable "Ae" to match the regular expression ^[_a-z][a-z0-9_]*$. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZrmBE5vLeH4FS8Q4kud&open=AZrmBE5vLeH4FS8Q4kud&pullRequest=4013

Check failure on line 70 in cpp/dolfinx/fem/Form.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "void *" with a more meaningful type. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZraT3JQqA6mqPYJkcJp&open=AZraT3JQqA6mqPYJkcJp&pullRequest=4013

Check warning on line 47 in python/test/unit/fem/test_custom_data.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable "Ae" to match the regular expression ^[_a-z][a-z0-9_]*$. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZraT3PMqA6mqPYJkcJ8&open=AZraT3PMqA6mqPYJkcJ8&pullRequest=4013

Check failure on line 295 in cpp/dolfinx/fem/assemble_vector_impl.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "void *" with a more meaningful type. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZraT3OIqA6mqPYJkcJ3&open=AZraT3OIqA6mqPYJkcJ3&pullRequest=4013

Check failure on line 374 in cpp/dolfinx/fem/assemble_matrix_impl.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "void *" with a more meaningful type. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZrb3rAQu-mtKnwcCd-k&open=AZrb3rAQu-mtKnwcCd-k&pullRequest=4013

Check failure on line 80 in cpp/dolfinx/fem/assemble_matrix_impl.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "void *" with a more meaningful type. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZrb3rAQu-mtKnwcCd-i&open=AZrb3rAQu-mtKnwcCd-i&pullRequest=4013

Check failure on line 229 in cpp/dolfinx/fem/assemble_matrix_impl.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "void *" with a more meaningful type. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZrb3rAQu-mtKnwcCd-j&open=AZrb3rAQu-mtKnwcCd-j&pullRequest=4013

Check warning on line 422 in cpp/dolfinx/fem/Form.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define and throw a dedicated exception instead of using a generic one. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZraT3JQqA6mqPYJkcJn&open=AZraT3JQqA6mqPYJkcJn&pullRequest=4013

Check warning on line 193 in python/test/unit/fem/test_custom_data.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable "Ae" to match the regular expression ^[_a-z][a-z0-9_]*$. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZraT3PMqA6mqPYJkcJ_&open=AZraT3PMqA6mqPYJkcJ_&pullRequest=4013

Check failure on line 127 in cpp/dolfinx/fem/assemble_scalar_impl.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "void *" with a more meaningful type. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZrb4afWc6ZwUjXdSccz&open=AZrb4afWc6ZwUjXdSccz&pullRequest=4013

Check failure on line 787 in cpp/dolfinx/fem/assemble_vector_impl.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "void *" with a more meaningful type. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZraT3OIqA6mqPYJkcJ6&open=AZraT3OIqA6mqPYJkcJ6&pullRequest=4013

Check failure on line 455 in cpp/dolfinx/fem/assemble_vector_impl.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "void *" with a more meaningful type. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZraT3OIqA6mqPYJkcJ4&open=AZraT3OIqA6mqPYJkcJ4&pullRequest=4013

Check failure on line 83 in cpp/dolfinx/fem/assemble_scalar_impl.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "void *" with a more meaningful type. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZrb4afWc6ZwUjXdSccy&open=AZrb4afWc6ZwUjXdSccy&pullRequest=4013

Check failure on line 417 in cpp/dolfinx/fem/Form.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "void *" with a more meaningful type. 

See more on https://sonarcloud.io/project/issues?id=FEniCS_dolfinx&issues=AZraT3JQqA6mqPYJkcJq&open=AZraT3JQqA6mqPYJkcJq&pullRequest=4013
View more details on SonarQubeCloud