Thunks: Disable 32-bit thunks unless a config option is set #3500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be necessary before FEX-Emu#3487 is merged. Once FEX-Emu#3487 is merged then 32-bit Vulkan thunk libraries is built which results in crashing in every 32-bit vulkan/dxvk game. Explicitly disable the thunking until this config option is set. Once X11 is as stable on 32-bit as 64-bit then this option can get removed. For testing purposes it's easy to set the environment variable `FEX_THUNKS32BITENABLED=1`
Sonicadvance1
force-pushed
the
32bit_syscall_config
branch
from
823d8c1 to
7735fe3
Compare
|
Not sure adding user-facing features as temporary workarounds is the right way forward here. Maybe this can instead be covered by the "forwarding groups" idea that we'll need for reliable window system integration either way. I'll do some more thinking in this direction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be necessary before #3487 is merged.
Once #3487 is merged then 32-bit Vulkan thunk libraries is built which results in crashing in every 32-bit vulkan/dxvk game.
Explicitly disable the thunking until this config option is set. Once X11 is as stable on 32-bit as 64-bit then this option can get removed.
For testing purposes it's easy to set the environment variable
FEX_THUNKS32BITENABLED=1