Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Great work 👍 #31

Open
jamiecoe opened this issue Oct 31, 2019 · 0 comments
Open

Great work 👍 #31

jamiecoe opened this issue Oct 31, 2019 · 0 comments

Comments

@jamiecoe
Copy link

jamiecoe commented Oct 31, 2019

Well done guys!!

You've managed to do a lot in a short space of time 🙌

  • Excellent README, very clear instructions (although be careful that everyone has google-chrome CLI tool installed). Great to see you documenting what you have learnt and what are your stretch goals
  • Hashing passwords and saving into DB - this was one of the most important lessons of this week!
  • Using JWTs to create sessions for logged in users
  • Separating your server into different files for different sections - I'm pleased to see you have put the brcypt functions into a separate file called encryption.js. This is much easier for an outside developer to understand and navigate, rather than just putting everything into one big file! I'd like to see you doing more of this, maybe separate files for different functions (eg: signInUser, addPost).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant