Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: prettier js formatting #33

Merged
merged 2 commits into from
Feb 20, 2023
Merged

chore: prettier js formatting #33

merged 2 commits into from
Feb 20, 2023

Conversation

oshinongit
Copy link
Contributor

No description provided.

@oshinongit oshinongit requested a review from bwallberg February 20, 2023 09:10
@oshinongit
Copy link
Contributor Author

Using the same config parameters as the template-typescript repo.

{
"useTabs": false,
"tabWidth": 2,
"singleQuote": true,
"trailingComma": "none"
}

bwallberg
bwallberg suggested changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@bwallberg bwallberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to add the config file to git?

bwallberg
bwallberg approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@bwallberg bwallberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oshinongit oshinongit merged commit 4bbdc42 into main Feb 20, 2023
@oshinongit oshinongit deleted the oliver/pretty-formating branch February 20, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwallberg bwallberg bwallberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oshinongit @bwallberg