Skip to content

Commit

Permalink
Merge pull request #2008 from Expensify/dsilva_preventSeveralCrashesF…
Browse files Browse the repository at this point in the history
…romHappening

Adding limit on how many times a crash command can run
  • Loading branch information
tylerkaraszewski authored Jan 13, 2025
2 parents a88cf54 + abb9d81 commit ba895ba
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions BedrockServer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1172,6 +1172,12 @@ bool BedrockServer::_wouldCrash(const unique_ptr<BedrockCommand>& command) {
return false;
}

// If this command crashed with more than one set of identifying values, it means
// we've already crashed more than one node. Let's fully block this command in that case.
if (commandIt->second.size() > 1) {
return true;
}

// Look at each crash-inducing command that has the same methodLine.
for (const STable& values : commandIt->second) {

Expand Down

0 comments on commit ba895ba

Please sign in to comment.