Clean up remaining files in libstuff

Expensify · Feb 10, 2025 · 38ec932 · 38ec932
1 parent 03d7409
commit 38ec932
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/libstuff/SPerformanceTimer.cpp b/libstuff/SPerformanceTimer.cpp
@@ -1,7 +1,7 @@
 #include <libstuff/libstuff.h>
 #include "SPerformanceTimer.h"
 
-SPerformanceTimer::SPerformanceTimer(string description, map<string, chrono::steady_clock::duration> defaults)
+SPerformanceTimer::SPerformanceTimer(const string& description, const map<string, chrono::steady_clock::duration>& defaults)
   : _description(description),
   _lastLogStart(chrono::steady_clock::now()),
   _defaults(defaults),

diff --git a/libstuff/SPerformanceTimer.h b/libstuff/SPerformanceTimer.h
@@ -3,7 +3,7 @@
 
 class SPerformanceTimer {
   public:
-    SPerformanceTimer(string description, map<string, chrono::steady_clock::duration> defaults = {});
+    SPerformanceTimer(const string& description, const map<string, chrono::steady_clock::duration>& defaults = {});
     void start(const string& type);
     void stop();
     void log(chrono::steady_clock::duration elapsed);

diff --git a/libstuff/STCPManager.cpp b/libstuff/STCPManager.cpp
@@ -342,7 +342,7 @@ unique_ptr<STCPManager::Port> STCPManager::openPort(const string& host, int rema
     return make_unique<Port>(s, host);
 }
 
-STCPManager::Port::Port(int _s, string _host) : s(_s), host(_host)
+STCPManager::Port::Port(int _s, const string& _host) : s(_s), host(_host)
 {
 }
 

diff --git a/libstuff/STCPManager.h b/libstuff/STCPManager.h
@@ -64,7 +64,7 @@ struct STCPManager {
 
     class Port {
       public:
-        Port(int _s, string _host);
+        Port(int _s, const string& _host);
         ~Port();
 
         // Attributes
-Original file line number
+Diff line change
@@ Expand Up @@
         return make_unique<Port>(s, host);
     }
-    STCPManager::Port::Port(int _s, string _host) : s(_s), host(_host)
+    STCPManager::Port::Port(int _s, const string& _host) : s(_s), host(_host)
     {
     }
@@ Expand Down @@