Add manager mctest tooltips to create expense flow #56759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to add-manager-mctest-tooltips-to-create-expense-flow
…to add-manager-mctest-tooltips-to-create-expense-flow
JKobrynski
reviewed
Feb 12, 2025
…to add-manager-mctest-tooltips-to-create-expense-flow
…to add-manager-mctest-tooltips-to-create-expense-flow
melvin-bot
bot
requested review from
DylanDylann
and removed request for
a team
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
…to add-manager-mctest-tooltips-to-create-expense-flow
fabioh8010
reviewed
Feb 14, 2025
| @@ -2145,6 +2145,10 @@ function shouldUseBoldText(report: OptionData): boolean { | |||
| return report.isUnread === true && notificationPreference !== CONST.REPORT.NOTIFICATION_PREFERENCE.MUTE && !isHiddenForCurrentUser(notificationPreference); | |||
| } | |||
|
|
|||
| function isSelectedManagerMcTest(email: string | null | undefined): boolean { | |||
There was a problem hiding this comment.
Could you add description for function?
There was a problem hiding this comment.
Also, why null? Is that really a possibility?
There was a problem hiding this comment.
|
|
||
| describe('TabSelectorItem Component', () => { | ||
| const title = 'Test Tab'; | ||
|
|
||
| beforeEach(() => { | ||
| // wrapOnyxWithWaitForBatchedUpdates(Onyx); |
There was a problem hiding this comment.
it was just my testing should be here, will remove
fabioh8010
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #55008
$ #55009
PROPOSAL:
Tests
Make sure you are added to beta for testing manager mctest
And you are on account that didn't send any expenses or dont have in Onyx
scanTestTooltipvalue inNVP_DISMISSED_PRODUCT_TRAININGkeyOpen FAB
Select Create Expense
When on Scan tab verify that tooltip for trying out testing receipt is visible
Add some file and go to next step
Go to select participant page
Verify that Manager McTest is visible and tooltip for selecting it for testing is visible
Select Manager McTest
On confirmation page verify that the tooltip above confirm button is visible
Open FAB
Select Create Expense
Select Manual
Add some amount
Go to select participant page
Verify that Manager McTest is visible and tooltip for selecting it for testing is visible
Select Manager McTest
On confirmation page verify that the tooltip above confirm button is visible
Open FAB
Select Create Expense
Select Distance
Add some waypoints
Go to select participant page
Verify that Manager McTest is visible and tooltip for selecting it for testing is visible
Select Manager McTest
On confirmation page verify that the tooltip above confirm button is visible
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mp4
Android: mWeb Chrome
iOS: Native
io1.mp4
iOS: mWeb Safari
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop
desktop.mp4