[HybridApp] Receive structured `initialProperties` (not as url) and improve url handling #56463

war-in · 2025-02-06T13:32:30Z

Explanation of Change

Fixed Issues

$
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

# Conflicts: # src/libs/actions/Travel.ts

mateuuszzzzz · 2025-02-06T14:21:17Z

src/components/InitialURLContextProvider.tsx

+            signInAfterTransitionFromOldDot(hybridAppSettings).then(() => {
+                if (splashScreenState === CONST.BOOT_SPLASH_STATE.HIDDEN) {
+                    return;
+                }
                setSplashScreenState(CONST.BOOT_SPLASH_STATE.READY_TO_BE_HIDDEN);
            });
            return;
        }
        Linking.getInitialURL().then((initURL) => {


I'm curious about the relevance of this line. Do we even need it?

Ah, it’s probably still needed for the standalone NewDot. Even though HybridApp is the only one available on the App Store and Play Store, we still need this for external contributors 🤔

Probably true but this is old code so I'm not sure

src/components/InitialURLContextProvider.tsx

mateuuszzzzz · 2025-02-06T14:31:30Z

src/types/modules/react-native.d.ts

-    closeReactNativeApp: (shouldSignOut: boolean, shouldSetNVP: boolean) => void;
-    completeOnboarding: (status: boolean) => void;
-    switchAccount: (newDotCurrentAccountEmail: string, authToken: string, policyID: string, accountID: string) => void;
+    closeReactNativeApp: ({shouldSignOut: boolean, shouldSetNVP: boolean}) => void;


What about creating separate types for those arguments? Nevertheless, both approaches seems fine to me

I don't want to create unnecessary types because value names are self-explaining (I can be wrong) here
If you and other reviewers think we should have separate types just let me know 🫡

war-in added 6 commits February 5, 2025 16:36

android part

93e132a

get rid of unnecessary singleNewDotEntry in initial url

d6004e3

pass objects to HybridAppModule methods

364af2c

improve comments

f0242fe

Merge branch 'main' into war-in/send-init-props-as-object

f5986f3

# Conflicts: # src/libs/actions/Travel.ts

post-merge fixes

1ea90a1

mateuuszzzzz reviewed Feb 6, 2025

View reviewed changes

src/components/InitialURLContextProvider.tsx Show resolved Hide resolved

mateuuszzzzz reviewed Feb 6, 2025

View reviewed changes

fix lint and apply suggestions

6c504ce

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HybridApp] Receive structured `initialProperties` (not as url) and improve url handling #56463

[HybridApp] Receive structured `initialProperties` (not as url) and improve url handling #56463

war-in commented Feb 6, 2025

mateuuszzzzz Feb 6, 2025

mateuuszzzzz Feb 6, 2025

war-in Feb 6, 2025

mateuuszzzzz Feb 6, 2025

war-in Feb 6, 2025 •

edited

Loading

[HybridApp] Receive structured initialProperties (not as url) and improve url handling #56463

Are you sure you want to change the base?

[HybridApp] Receive structured initialProperties (not as url) and improve url handling #56463

Conversation

war-in commented Feb 6, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

mateuuszzzzz Feb 6, 2025

Choose a reason for hiding this comment

mateuuszzzzz Feb 6, 2025

Choose a reason for hiding this comment

war-in Feb 6, 2025

Choose a reason for hiding this comment

mateuuszzzzz Feb 6, 2025

Choose a reason for hiding this comment

war-in Feb 6, 2025 • edited Loading

Choose a reason for hiding this comment

[HybridApp] Receive structured `initialProperties` (not as url) and improve url handling #56463

[HybridApp] Receive structured `initialProperties` (not as url) and improve url handling #56463

war-in Feb 6, 2025 •

edited

Loading