-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update QAB titles for money request, track actions and perdiem #56324
base: main
Are you sure you want to change the base?
Conversation
Issues to fix:
Unit test:
|
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@etCoderDysto Overall the. code looks good. Can you complete the pending two checklist items? Also w've got a few lint fixes. |
Thanks! Yes, I am working on them @mananjadhav. I will ping you when the code is ready for further review. |
Any ETA on the PR? |
Sorry for the delay! PR will be ready for review by EOD. |
Thanks for the update. 🙏 |
@mananjadhav I have fixed these issues. PR is ready for further review |
Explanation of Change
In this PR we will change QAB title for create expense and track expense. The QAB titles are described bellow:
Fixed Issues
$ #55456
PROPOSAL: #55456 (comment)
Tests
Same as QA steps
Offline tests
Same as QA steps
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Precondition: User should enable per diem feature in a workspace
Create expense
titleScan receipt
titleTrack distance
titleCreate per diem
titleCreate per diem
and verify that you are navigated toPer diem
tab onCreate expense
RHPCreate expense
titleScan receipt
titleTrack distance
titlePR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop