Update delegate flow to use modal #56231

cretadn22 · 2025-02-03T11:06:28Z

Explanation of Change

Fixed Issues

$ #55718
PROPOSAL: #55718 (comment)

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Go to Account settings > Security.
Click Add copilot.
Select a user, select access level and proceed to confirmation page.
Click Add copilot.
Enter correct magic code.
Click on the same member under "These members can access your account".
Click Change access level.
Select a different access level.
On magic code page when changing access level for existing copilot, it should display a countdown and "Code requested. Please check your device." message.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-02-06.at.19.49.03.mov

Android: mWeb Chrome

Screen.Recording.2025-02-06.at.19.43.43.mov

iOS: Native

Screen.Recording.2025-02-06.at.19.47.22.mov

iOS: mWeb Safari

Screen.Recording.2025-02-06.at.19.38.43.mov

MacOS: Chrome / Safari

Screen.Recording.2025-02-06.at.19.32.21.mp4

MacOS: Desktop

Screen.Recording.2025-02-06.at.19.45.07.mov

melvin-bot · 2025-02-04T04:49:29Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

cretadn22 · 2025-02-04T05:00:32Z

src/pages/settings/Security/AddDelegate/UpdateDelegateRole/UpdateDelegateMagicCodePage.tsx

    const currentDelegate = account?.delegatedAccess?.delegates?.find((d) => d.email === login);
-    const updateDelegateErrors = account?.delegatedAccess?.errorFields?.addDelegate?.[login];
+    const updateDelegateErrors = account?.delegatedAccess?.errorFields?.updateDelegateRole?.[login];


We should update it to use the correct error field so that the error message is displayed properly when an incorrect code is entered. This isn't directly related to this task, but I noticed it while testing this PR.

jayeshmangwani · 2025-02-06T07:53:12Z

@cretadn22 There's a bug when pasting the magic code. The API call happens in the background, but the input page doesn't reflect this. Additionally, the RHP doesn’t show a successful update for the access level change. Please check the video below—I pasted the code, but the UI doesn’t show anything even though the API call was made.

paste-bug.mov

cretadn22 · 2025-02-06T11:58:18Z

@jayeshmangwani The RHP should close after the API request is successful. I fixed that bug and made some improvements to remove the redundant route

jayeshmangwani · 2025-02-06T12:12:21Z

Thanks for fixing it, I'll check again in an hour

jayeshmangwani · 2025-02-06T15:32:42Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android.mov

Android: mWeb Chrome

mweb-chrome.mov

iOS: Native

iOS.mov

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

jayeshmangwani

LGTM 🚀

aldo-expensify · 2025-02-11T18:06:24Z

Does this error happen in main?

jayeshmangwani · 2025-02-11T18:48:12Z

Does this error happen in main?

Yes, we’re seeing this console error on main as well. We could fix it in this PR, though I’m not sure if the same bug has been reported anywhere.

aldo-expensify · 2025-02-11T18:52:00Z

Does this error happen in main?

Yes, we’re seeing this console error on main as well. We could fix it in this PR, though I’m not sure if the same bug has been reported anywhere.

I think it is out of scope, I just wanted to confirm that we were not introducing a new error.

OSBotify · 2025-02-11T19:01:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-02-12T02:07:24Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.0.97-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

cretadn22 added 4 commits February 3, 2025 18:04

update delegate flow use modal

c87b201

fix type import

1b60e51

new main

9c256c5

update sent validated code message

955fd76

cretadn22 marked this pull request as ready for review February 4, 2025 04:49

cretadn22 requested a review from a team as a code owner February 4, 2025 04:49

melvin-bot bot requested review from jayeshmangwani and removed request for a team February 4, 2025 04:49

cretadn22 commented Feb 4, 2025

View reviewed changes

cretadn22 added 2 commits February 4, 2025 12:00

clear error

46489da

remove optimistic data

3d7c502

cretadn22 added 3 commits February 6, 2025 18:47

remove route

6dc8bb2

remove route

6f1f09d

minor update

2a24bbc

jayeshmangwani approved these changes Feb 11, 2025

View reviewed changes

melvin-bot bot requested a review from aldo-expensify February 11, 2025 09:06

aldo-expensify approved these changes Feb 11, 2025

View reviewed changes

aldo-expensify merged commit cbceb93 into Expensify:main Feb 11, 2025
20 checks passed

github-actions bot mentioned this pull request Feb 12, 2025

Deploy Checklist: New Expensify 2025-02-12 #56710

Open

29 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update delegate flow to use modal #56231

Update delegate flow to use modal #56231

cretadn22 commented Feb 3, 2025 •

edited

Loading

melvin-bot bot commented Feb 4, 2025

cretadn22 Feb 4, 2025

jayeshmangwani commented Feb 6, 2025

cretadn22 commented Feb 6, 2025

jayeshmangwani commented Feb 6, 2025

jayeshmangwani commented Feb 6, 2025 •

edited

Loading

jayeshmangwani left a comment

aldo-expensify commented Feb 11, 2025

jayeshmangwani commented Feb 11, 2025

aldo-expensify commented Feb 11, 2025

OSBotify commented Feb 11, 2025

github-actions bot commented Feb 12, 2025

Update delegate flow to use modal #56231

Update delegate flow to use modal #56231

Conversation

cretadn22 commented Feb 3, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 4, 2025

cretadn22 Feb 4, 2025

Choose a reason for hiding this comment

jayeshmangwani commented Feb 6, 2025

cretadn22 commented Feb 6, 2025

jayeshmangwani commented Feb 6, 2025

jayeshmangwani commented Feb 6, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

jayeshmangwani left a comment

Choose a reason for hiding this comment

aldo-expensify commented Feb 11, 2025

jayeshmangwani commented Feb 11, 2025

aldo-expensify commented Feb 11, 2025

OSBotify commented Feb 11, 2025

github-actions bot commented Feb 12, 2025

cretadn22 commented Feb 3, 2025 •

edited

Loading

jayeshmangwani commented Feb 6, 2025 •

edited

Loading