fix: in debug menu toggle action delay #55442
Open
+1
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
The
Lottie
animation consumes high CPU, preventing therunAfterInteractions
callback from executing. This happens becauseInteractionManager
schedules long-running work only after all interactions and animations have completed.So we need to replace
InteractionManager
torequestAnimationFrame
Fixed Issues
$ #54767
PROPOSAL: #54767 (comment)
Tests
Offline tests
Same above
QA Steps
Same above
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
toggle-android-native.mp4
Android: mWeb Chrome
toggle-android-mweb.mp4
iOS: Native
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-01-18.at.10.29.20.mp4
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-01-18.at.08.33.04.mp4
MacOS: Chrome / Safari
Screen.Recording.2025-01-18.at.8.15.14.AM.mov
MacOS: Desktop
Screen.Recording.2025-01-18.at.8.43.06.AM.mov