(2/2) Add support for all reportAction types in ChatListItem - use ReportActionItem in ChatListItem

[wildan-m]

Explanation of Change

Second PR to add support for all reportAction types in ChatListItem, this part replace chatlistItem inner component with ReportActionItem

Fixed Issues

$ #51296
PROPOSAL: #51296 (comment)

Tests

Pre-condition: Login to account with various chat types

1. Go to Search option from bottom tab.
2. Click on Chat type from LHP, choose Chats
3. Tap on search item with image, verify the image shown in the modal
4. Tap on search item with attachment, verify the image shown in the modal
5. Ensure the search results feature works the same as staging

• Verify that no errors appear in the JS console

Offline tests

Same as test

QA Steps

Same as test

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Kapture.2024-12-28.at.11.16.37.mp4

Android: mWeb Chrome

Kapture.2024-12-28.at.11.20.10.mp4

iOS: Native

Kapture.2024-12-28.at.09.19.43.mp4

iOS: mWeb Safari

Kapture.2024-12-28.at.09.40.09.mp4

MacOS: Chrome / Safari

Kapture.2024-12-28.at.09.11.12.mp4

MacOS: Desktop

Kapture.2024-12-28.at.11.11.31.mp4

[wildan-m]

@luacmartins @allgandalf this is draft PR for the second part.
I have some parts to confirm.

Will the logic to show icons the same between reportactionitem and chatlistitem?

PureReportActionItem might render ReportActionItemSingle and use getReportActionActorAccountID, to determine the icons from personalDetails, but SearchReportAction doesn't have ownerAccountID, actorAccountID, etc to fullfill the logic.

will SearchReportAction / SearchReport return required props in the upcoming BE updates? (including its required personalDetails)

[luacmartins]

@wildan-m Search already returns personalDetailsList which should be used. As for the missing reportAction keys, yes, we need to update the BE to return them. I'll work on adding actorAccountID to the chat response now, so that case can be properly rendered to begin with.

[luacmartins]

PR to add actorAccountID is in review

[wildan-m]

@luacmartins @allgandalf There is a new ESLint rule that enforces the use of a default value of '0' or undefined instead of '-1'. I am concerned that this change could potentially cause regressions, especially because there are numerous occurrences in the PureReportActionItem, ReportActionItemSingle and their subcomponents. Should this be addressed in this pull request?

error  Default the number ID to `CONST.DEFAULT_NUMBER_ID` instead. See: https://github.com/Expensify/App/blob/main/contributingGuides/STYLE.md#default-value-for-inexistent-IDs  rulesdir/no-default-id-values

[luacmartins]

@luacmartins @allgandalf There is a new ESLint rule that enforces the use of a default value of '0' or undefined instead of '-1'. I am concerned that this change could potentially cause regressions, especially because there are numerous occurrences in the PureReportActionItem, ReportActionItemSingle and their subcomponents. Should this be addressed in this pull request?

Let's open a separate PR for that and get it merged first, so if there are regressions it's isolated to that one PR and it's easy to revert

[allgandalf]

@wildan-m can you please fix the workflows

[wildan-m]

There is CalendarPickerTest failures that seems comes from other PR https://expensify.slack.com/archives/C01GTK53T8Q/p1738397681223439

[luacmartins]

Thanks for working on the onyx bump

[fabioh8010]

@wildan-m @luacmartins Onyx bump PR was merged!

[wildan-m]

Onyx bump PR was merged!

@fabioh8010 thank you!

@allgandalf @luacmartins The code has been updated to use UseOnyxOptions from there

[wildan-m]

@luacmartins @allgandalf @fabioh8010

I've tried to change usePersonalDetails in ReportActionItemSingle to const [personalDetails] = useOnyx(ONYXKEYS.PERSONAL_DETAILS_LIST);

App/src/pages/home/report/ReportActionItemSingle.tsx

Line 101 in 4bf233e

const personalDetails = usePersonalDetails();

But it does not pass this test

App/tests/unit/ReportActionItemSingleTest.ts

Lines 69 to 76 in 4bf233e

	it('renders secondary Avatar properly', async () => {
	const expectedSecondaryIconTestId = 'SvgDefaultAvatar_w Icon';
	await setup();
	await waitFor(() => {
	expect(screen.getByTestId(expectedSecondaryIconTestId)).toBeOnTheScreen();
	});
	});

Not sure what's wrong, even when we change it in main branch with react-native-onyx's useOnyx, that's show the same error. It said

 Unable to find an element with testID: SvgDefaultAvatar_w Icon

Like the error here.

What I've tried:

• Inspect variables in both cases. it show identical value
• Add timeout to screen.getByTestId but that's keep showing the error.

Have you ever experienced it?

[luacmartins]

I haven't experienced it, but my initial thought is that it's a race condition because usePersonalDetails uses a HOC provider vs the hook in the component. Is it possible that in the first case the whole tree waits for data to be available vs in the second case we render the tree and then re-render once data loads?

[wildan-m]

I haven't experienced it, but my initial thought is that it's a race condition because usePersonalDetails uses a HOC provider vs the hook in the component. Is it possible that in the first case the whole tree waits for data to be available vs in the second case we render the tree and then re-render once data loads?

@luacmartins thanks for the insight, I think we can move the render process after setup

                await setup();
                LHNTestUtils.getDefaultRenderedReportActionItemSingle(shouldShowSubscriptAvatar, fakeReport, fakeReportAction);
                await waitFor(() => {
                    expect(screen.getByTestId(expectedSecondaryIconTestId)).toBeOnTheScreen();
                });

Now the test passed 😆

Any update regarding the missing fields?

[luacmartins]

Any update regarding #54228 (comment)?

I'm still working on the PR. Sorry for the delay.

[luacmartins]

PR returning the additional data is in review