Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expense - Merchant is shown as a requirement for p2p expense #56640

Closed
8 tasks done
IuliiaHerets opened this issue Feb 11, 2025 · 6 comments
Closed
8 tasks done

Expense - Merchant is shown as a requirement for p2p expense #56640

IuliiaHerets opened this issue Feb 11, 2025 · 6 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.96-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Workspace has a default workspace.
  1. Go to staging.new.expensify.com
  2. Go to 1:1 DM.
  3. Click + > Create expense > Manual.
  4. Enter amount > Next.
  5. On confirmation page, click Merchant.
  6. Enter merchant and save it.
  7. Click Merchant, clear the merchant and save it.
  8. Note that the merchant can be cleared as merchant is not a requirement in p2p expense.
  9. Open FAB > Create expense > Manual.
  10. Enter amount > Next.
  11. On confirmation page, click Merchant.
  12. Enter merchant and save it.
  13. Click To field.
  14. Select a user with no chat history.
  15. Click Show more > Merchant.
  16. Clear the merchant and save it.

Expected Result:

There should be no error when clearing merchant field when the destination is 1:1 DM as merchant is not a requirement in p2p expense.

Actual Result:

User is unable to clear merchant field when the destination is 1:1 DM and merchant is not a requirement in p2p expense.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6739179_1739250012638.20250211_124243.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment labels Feb 11, 2025
Copy link

melvin-bot bot commented Feb 11, 2025

Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Feb 11, 2025

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Feb 11, 2025

💬 A slack conversation has been started in #expensify-open-source

@melvin-bot melvin-bot bot added the Daily KSv2 label Feb 11, 2025
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 11, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@nkdengineer
Copy link
Contributor

Handled it here #56638

@m-natarajan
Copy link

Not reproducible

Recording.976.mp4

@Julesssss Julesssss removed the DeployBlockerCash This issue or pull request should block deployment label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants