Deploy Checklist: New Expensify 2025-02-11

[github-actions]

Release Version: 9.0.96-1
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Some initial fixes and code style updates #1
• Fix spaces #2
• Fix babel build on master #5
• fix: Second approver unapproval shows 'Waiting for first approver' in next steps #52297
• fix: Handle distance unit update when sharing #54048
• [NO QA] feat: Step 4 logic #54280
• fix: strange next steps message format #54454
• fix: add missing violation data #54603
• fix: when selecting categories, the selected categories get reset - v2 #54998
• Fix open app #55139
• Fix chrome android input bug #55210
• Fix Composer context menu not opening #55647
• Prevent self approvals #55740
• fix: Removing the transaction's ID from other duplicate violation data when deleting one of the duplicate expenses. #55801
• Add chats "In" filter back #55917
• Updating Classic/AccountDetails doc with image and new copy #55919
• Web - Chat - Pasted message not always displays no hyperlink format w… #55932
• fix 55705 LHN - user name disappear from ws rooms admins #55974
• feat: skip participant step in create flow #56090
• Always scroll to top when selecting item #56098
• [NO QA] Add files via upload #56128
• Fix new message not auto scrolled in search RHP #56293
• fix: pending is displayed when deleting the distance rate #56297
• Fix Chat Report is shown as the report name on the system message text #56298
• fix: selection has blue border when redirected from OD #56301
• fix: Keyboard overlaps the composer when starting a new thread #56304
• fix: Add Description Hints to NewDot #56317
• fix: change the condition to render Expensify card page content correctly #56331
• Filter out read only report from share log options #56398
• [No QA] Fix syntax in testBuildHybrid.yml #56400
• fix: Scan - Delete option is displayed for an admin which causes an error. #56403
• Create Track-Travel-Analytics.md #56404
• fix: inccorect system message when deleteting a report from od #56440
• [No QA] fix default ID lint rule #56458
• Fix contact details page not opening #56487
• [No QA] feat: bump jvm heap memory size #56489
• [No QA] Create reusable validateActor action (v2) #56501
• [No QA] Add ENVIRONMENT to .env.example to make sure it is set for OldDot #56506
• Fix - Expensify Card - Step indicator does not change when returning to adding details step #56542
• feat: policy custom rules #56548
• [No QA] Add violation for custom rules #56553
• Create Set-up-rules.md #56557
• Improve custom rules formatting #56562
• [No QA] feat: field level violations for custom rules #56563
• [No QA]Allow Javascript tests to be run on forks #56617
• fix create expense flow regression #56638
• [NO QA] Cherry-pick 402fc9142c2514d94b7c429a084f9d342093a358 #56707

Internal QA:

• Make Retry Payment button available for amount owed overdue state #56558 - @blimpich

Deploy Blockers:

• [Due for payment 2025-02-19] [Due for payment 2025-02-18] Android - Group - Device back button on members list, redirects to chat instead of details. #56514
• Reports - Chat name is not wrapped properly when report name is long and has no limit #56529
• [Due for payment 2025-02-19] [$250] Expense - Expense is submitted to the workspace chat when 1:1 DM is the destination #56630
• Distance -Rate is not selected and error when submitting distance expense to default workspace #56631
• Rules - Text with mark down is not rendered correctly and description changes after saving #56632
• Split - Members on the confirmation page show hover effect but not clickable #56633
• Per diem - User can select 1:1 DM or workspace with no per diem rate as destination #56634
• Expense - Merchant is shown as a requirement for p2p expense #56640
• Rules - Custom rule description is cleared after logging out and logging in #56641
• Distance expense - Delete and replace options are present in distance map menu #56647
• Web - Distance - No option to select participant when create distance expense via FAB #56659
• Expense - Workspace list disappears from recipient list after selecting self DM #56662
• Expense - Expense is submitted to self DM when destination changes from self DM to other user #56664
• [$250] Invoice - Clicking on To field in Invoice detail takes user to the participant selector page #56670
• Rules - Custom rule description has no description text limit, unlimited text #56679
• [$250][Offline] Android - Workspace - Unresponsive confirm button and several WS created in offline mode #56696
• Scan receipt offline - Replace receipt asked to fill out inform instead of scanning #56700

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics for this release version and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked Firebase Crashlytics for the previous release version and verified that the release did not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[lakchote]

Demoted #5664 for this reason.

[izarutskaya]

Regression is 49% completed.

Unchecked PRs:
#54454 - found issue #54454 (comment) on Web, mWeb and Android Pending validation on Desktop and iOS
#55647 - failing on Android only with #55647 (comment)
#55740 - failing with issues #55740 (comment)
#55932 - failing with original bug id #55932 (comment)
#56090 - failing on Android and iOS only #56090 (comment)
#56098 - failing mWeb and Android with #56098 (comment)
#56487 - #56487 (comment)
#56548 -failing with issue #56548 (comment)
#56562 - failing with issue #56562 (comment)

DB:
#56514
#56529
#56630
#56631
#56632
#56633
#56634
#56640

[mvtglobally]

Regression is 98% completed.

Unchecked PRs:
#52297 - Pending validation on Desktop and IOS
#55210 - Failing with #56681. Checking off
#55740 - failing with issues #56644, & #56645
#55932 - failing with original bug id #55932 (comment)
#56331 - Pending validation on IOS
#56542 - Pending validation on IOS
#56548 -failing with issue #56641, & #56632
#56562 - failing with issue #56632

DB:
#56514
#56529
#56630
#56631
#56633
#56640
#56659
#56662
#56670
#56679

[Julesssss]

• Checked off [Due for payment 2025-02-19] [Due for payment 2025-02-18] Android - Group - Device back button on members list, redirects to chat instead of details. #56514

[amyevans]

checked off #56558

[mvtglobally]

Regression is completed.

Unchecked PRs:
#55740 - failing with issues #56644, & #56645
#55932 - failing with original bug id #55932 (comment)
#56548 -failing with issue #56641, & #56632
#56562 - failing with issue #56632

DB:
#56630
#56631
#56633
#56640
#56659
#56662
#56670
#56679
#56696

[MarioExpensify]

Demoting #56670 - context

[Julesssss]

• Checked off Split - Members on the confirmation page show hover effect but not clickable #56633
• fix create expense flow regression #56638 will fix multiple issues

[Julesssss]

Checking off another few PRs. We're about to get #56638 tested which potentially fixes 3/4 more blockers

[mvtglobally]

Few Critical TCs failing today with older KIs

https://expensify.testrail.io/index.php?/tests/view/5580935 - Reopened the issue #48378 (comment)
https://expensify.testrail.io/index.php?/tests/view/5581325 & https://expensify.testrail.io/index.php?/tests/view/5583411 - #53895 - Free trial banner doesn't show up on Concierge chat anymore. & #56502 Onboarding - The 'take a 2-minute tour' task doesn’t get auto-checked when finished.
https://expensify.testrail.io/index.php?/tests/view/5581379 - #47916 (comment)
https://expensify.testrail.io/index.php?/tests/view/5581381 - Blocked as #55894
https://expensify.testrail.io/index.php?/tests/view/5582981 & https://expensify.testrail.io/index.php?/tests/view/5582974 & https://expensify.testrail.io/index.php?/tests/view/5583531 - #55771
https://expensify.testrail.io/index.php?/tests/view/5583432 - Step 6 failed, the modal does not appear. Only appears if the user chooses the first option ‘1-10 employees’. KI:#55670
https://expensify.testrail.io/index.php?/tests/view/5583941 - #56515

[jasperhuangg]

Closed #56700

[Julesssss]

• Checked off Expense - Workspace list disappears from recipient list after selecting self DM #56662
• Checked off Expense - Merchant is shown as a requirement for p2p expense #56640
• Checked off Distance -Rate is not selected and error when submitting distance expense to default workspace #56631
• Checked off [Due for payment 2025-02-19] [$250] Expense - Expense is submitted to the workspace chat when 1:1 DM is the destination #56630

[Julesssss]

Checked off #56659

[Julesssss]

• Timing good
• Github status good
• Firebase crashes are trending down, with no new issues 🎉 (likely due to keychain and secure log bugfixes from last week)

[Julesssss]