Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Description" does not display for non admin in workspace overview #56425

Open
1 of 8 tasks
m-natarajan opened this issue Feb 5, 2025 · 5 comments
Open
1 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Needs Reproduction Reproducible steps needed retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause

Comments

@m-natarajan
Copy link

m-natarajan commented Feb 5, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @flaviadefaria
Slack conversation (hyperlinked to channel name): migrate

Action Performed:

  1. Go to workspaces
  2. Click on the workspace name

Expected Result:

User should be taken to the overview with useful description allowing companies to add mor information including links to their internal expense policies

Actual Result:

Description is not appearing for a member and no useful information for the employee

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Please refer to the [OP](https://expensify.slack.com/archives/C07NMDKEFMH/p1738763844143929)for more info about screenshots [View all open jobs on GitHub](https://github.com/Expensify/App/issues?q=is%3Aopen+is%3Aissue+label%3A%22Help+Wanted%22)
@m-natarajan m-natarajan added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Needs Reproduction Reproducible steps needed retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause labels Feb 5, 2025
Copy link

melvin-bot bot commented Feb 5, 2025

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@ZhenjaHorbach
Copy link
Contributor

ZhenjaHorbach commented Feb 5, 2025

I can to reproduce it this way
If in this case we should still see the description for a member (Which is logical since the admin has a default description) I can take as a C+ following this ! :

  1. Open workspace as admin
  2. Remove description
  3. As a result, we see the default description for the admin
Image
  1. But for member description disappeared
Image

@FitseTLT
Copy link
Contributor

FitseTLT commented Feb 5, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Description" does not display for non admin in workspace overview

What is the root cause of that problem?

We only display description if the policy description is non empty or the current user is admin

{(!StringUtils.isEmptyString(policy?.description ?? '') || !readOnly) && (
<OfflineWithFeedback

What changes do you think we should make in order to solve the problem?

We can remove the condition to display it always

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Not needed just simple expectation change

What alternative solutions did you explore? (Optional)

@huult
Copy link
Contributor

huult commented Feb 7, 2025

I think this is not a bug. We don’t want to display the default description for workspace members. The description should only be shown to members after the workspace admin has edited or set it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Needs Reproduction Reproducible steps needed retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause
Projects
Status: No status
Development

No branches or pull requests

6 participants