Merge pull request #56397 from nkdengineer/fix/56307

fix: App is stuck on the confirmation page when submitting expense
Expensify · Feb 5, 2025 · f22c07b · f22c07b
2 parents 4bf233e + 46d1920
commit f22c07b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/libs/API/parameters/AddTrackedExpenseToPolicyParams.ts b/src/libs/API/parameters/AddTrackedExpenseToPolicyParams.ts
@@ -17,7 +17,7 @@ type AddTrackedExpenseToPolicyParams = {
     customUnitRateID?: string;
     policyID: string;
     transactionID: string;
-    actionableWhisperReportActionID: string;
+    actionableWhisperReportActionID: string | undefined;
     moneyRequestReportID: string;
     reportPreviewReportActionID: string;
     modifiedExpenseReportActionID: string;

diff --git a/src/libs/API/parameters/ConvertTrackedExpenseToRequestParams.ts b/src/libs/API/parameters/ConvertTrackedExpenseToRequestParams.ts
@@ -7,7 +7,7 @@ type ConvertTrackedExpenseToRequestParams = {
     payerAccountID: number;
     chatReportID: string;
     transactionID: string;
-    actionableWhisperReportActionID: string;
+    actionableWhisperReportActionID: string | undefined;
     createdChatReportActionID?: string;
     moneyRequestReportID: string;
     moneyRequestCreatedReportActionID: string | undefined;

diff --git a/src/libs/actions/IOU.ts b/src/libs/actions/IOU.ts
@@ -4157,7 +4157,7 @@ type AddTrackedExpenseToPolicyParam = {
     merchant: string;
     transactionID: string;
     reimbursable: boolean;
-    actionableWhisperReportActionID: string;
+    actionableWhisperReportActionID: string | undefined;
     moneyRequestReportID: string;
     reportPreviewReportActionID: string;
     modifiedExpenseReportActionID: string;
@@ -4174,7 +4174,7 @@ function convertTrackedExpenseToRequest(
     payerEmail: string,
     chatReportID: string,
     transactionID: string,
-    actionableWhisperReportActionID: string,
+    actionableWhisperReportActionID: string | undefined,
     createdChatReportActionID: string | undefined,
     moneyRequestReportID: string,
     moneyRequestCreatedReportActionID: string | undefined,
@@ -4427,7 +4427,7 @@ function requestMoney(requestMoneyInformation: RequestMoneyInformation) {
 
     switch (action) {
         case CONST.IOU.ACTION.SUBMIT: {
-            if (!linkedTrackedExpenseReportAction || !actionableWhisperReportActionID || !linkedTrackedExpenseReportID) {
+            if (!linkedTrackedExpenseReportAction || !linkedTrackedExpenseReportID) {
                 return;
             }
             const workspaceParams =