Prevent It's not here message when logging in #55721 #56228

OmarKoueifi · 2025-02-03T08:32:39Z

Explanation of Change

Fixed Issues

$ #55721
PROPOSAL: #55721 (comment)

Tests

A. Test Access When Logged Out and Switching Accounts

1. On Account A, navigate to any report (e.g., a concierge, chat, or expense report) and note the report ID.
2. Log out of Account A.
3. Open the report URL using the noted report ID (e.g., https://staging.new.expensify.com/r/72105063) while logged out.
4. Log in with Account B, which doesn't have access to the selected report.
Expected Result: The app should redirect to your most recently accessed report (or the Concierge report) rather than displaying "Hmm... it's not here".

B. Test Access When Already Signed In (Unauthorized Report)

1. Log in with an account that should not have access to a specific report.
2. Navigate directly to the report using its link.
Expected Result: The app should display "Hmm... it's not here" to indicate access is not permitted.

C. Test Access When Already Signed In (Authorized Report)

1. Log in with an account that has access to a known report.
2. Navigate to the report using its link.
Expected Result: The report opens normally without any redirection or error messages.
Verify that no errors appear in the JS console

Offline tests

N/A
Can't sign in when offline

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: mWeb Chrome

no.access.android.mov

iOS: mWeb Safari

no.access.ios.mov

MacOS: Chrome / Safari

** Chrome **

report.with.no.access.mov

** Safari **

report.with.no.access.mov

github-actions · 2025-02-03T08:32:51Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

OmarKoueifi · 2025-02-03T08:36:48Z

I have read the CLA Document and I hereby sign the CLA

OmarKoueifi · 2025-02-03T22:13:14Z

recheck

OmarKoueifi · 2025-02-03T22:14:20Z

I have read the CLA Document and I hereby sign the CLA

OmarKoueifi · 2025-02-03T22:14:31Z

recheck

melvin-bot · 2025-02-03T22:15:32Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rushatgabhane · 2025-02-04T00:50:06Z

src/libs/actions/Report.ts

@@ -2942,6 +2943,20 @@ function openReportFromDeepLink(url: string) {
                                return;
                            }

+                            // Check if the report exists in the collection
+                            const report = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${reportID}`];


maybe a noobie questions:
@OmarKoueifi will onyx always have the report at this point in code? Can there be a case where the report is being fetched, so it isn't in onyx. But the report actually exists.

@rushatgabhane
To my understanding and based on my testing, the report should always be in Onyx at this point. However, I’m still new to this project and haven’t explored all edge cases. If there's a scenario where it might not be available yet, I’d love to understand how to reproduce that.

I initially tried another approach using onyx.connect with the key ${ONYXKEYS.COLLECTION.REPORT}${thread.reportID} and checking inside the callback. That seemed to work, but I ultimately went with the current solution since it's being used in many place in code allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${reportID}`];.

I also wanted to add a unit test for this, but I couldn’t find any existing test cases for openReportFromDeepLink. I’m still getting familiar with how tests are structured in this repo, if there’s a recommended place to add it or an example of a similar function with tests, I’d appreciate any guidance!

rushatgabhane · 2025-02-05T06:33:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Screen.Recording.2025-02-05.at.07.28.25.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

New account sign up

not authorized and not logged in

Takes me to last accessed report

Already logged in and to 404

sign in and authorized

MacOS: Desktop

rushatgabhane

LGTM!

@OmarKoueifi to test it on iOS and Android, you can run these commands -

npx uri-scheme open 'new-expensify://r/1234' --ios
npx uri-scheme open 'new-expensify://r/1234' --android

Beamanator

Looking great to me! Very interesting, the question about "will the reportID exist - cuz it looks like we do openReport a few lines above (line 2888)... Does that actually load the report into Onyx BEFORE our new code runs? (probably yes b/c our new code runs after waitForUserSignIn)

I have decent confidence this should work perfectly 🚀 Let's shipittt

Beamanator · 2025-02-05T17:45:39Z

CONFLICT (submodule): Merge conflict in Mobile-Expensify

Hmmmmmmm @rushatgabhane is that something we need to fix in this PR? 😅

@OmarKoueifi mind pulling main to see if that gets fixed in the Reassure Performance Tests / perf-tests (pull_request) test? 🙏

OmarKoueifi · 2025-02-05T17:54:07Z

Done!

Beamanator · 2025-02-05T18:32:13Z

Thanks! Rerunning github actions

Beamanator · 2025-02-05T19:04:51Z

GoogleTagManagerTest not updated in this change, so no updates needed there - and performance tests are looking good! LGTM

melvin-bot · 2025-02-05T19:05:06Z

@Beamanator looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

Beamanator · 2025-02-05T19:05:30Z

Not emergency, as mentioned above, the 1 failing check was ESlint, and it failed on a file that wasn't modified in this PR

OSBotify · 2025-02-05T19:13:52Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-02-06T22:02:28Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 9.0.95-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

izarutskaya · 2025-02-07T08:27:02Z

@OmarKoueifi Found issue on apps #56521

github-actions · 2025-02-11T02:13:47Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.95-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

Prevent It's not here message when logging in Expensify#55721

0adb14c

CLABotify added a commit to Expensify/CLA that referenced this pull request Feb 3, 2025

@OmarKoueifi has signed the CLA in Expensify/App#56228

3e94c68

OmarKoueifi marked this pull request as ready for review February 3, 2025 22:15

OmarKoueifi requested a review from a team as a code owner February 3, 2025 22:15

melvin-bot bot requested review from rushatgabhane and removed request for a team February 3, 2025 22:15

rushatgabhane reviewed Feb 4, 2025

View reviewed changes

rushatgabhane approved these changes Feb 5, 2025

View reviewed changes

melvin-bot bot requested a review from Beamanator February 5, 2025 06:34

Beamanator approved these changes Feb 5, 2025

View reviewed changes

Merge branch 'main' into prevent-error-when-logging-in

9b221aa

Beamanator merged commit 4c7cdb0 into Expensify:main Feb 5, 2025
15 of 16 checks passed

melvin-bot bot added the Emergency label Feb 5, 2025

Beamanator removed the Emergency label Feb 5, 2025

github-actions bot mentioned this pull request Feb 6, 2025

Deploy Checklist: New Expensify 2025-02-06 #56482

Closed

izarutskaya mentioned this pull request Feb 7, 2025

[$250] Chat - Unable to redirect to hybrid app via link #56521

Open

8 tasks

melvin-bot bot mentioned this pull request Feb 11, 2025

[Due for payment 2025-02-18] [$500][not here] Prevent "Hmm... It's not here" when logging in by immediately navigating to a report user has access to #55721

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prevent It's not here message when logging in #55721 #56228

Prevent It's not here message when logging in #55721 #56228

OmarKoueifi commented Feb 3, 2025 •

edited

Loading

github-actions bot commented Feb 3, 2025 •

edited

Loading

OmarKoueifi commented Feb 3, 2025

OmarKoueifi commented Feb 3, 2025

OmarKoueifi commented Feb 3, 2025

OmarKoueifi commented Feb 3, 2025

melvin-bot bot commented Feb 3, 2025

rushatgabhane Feb 4, 2025 •

edited

Loading

OmarKoueifi Feb 4, 2025

rushatgabhane commented Feb 5, 2025

New account sign up

not authorized and not logged in

Already logged in and to 404

sign in and authorized

rushatgabhane left a comment

Beamanator left a comment

Beamanator commented Feb 5, 2025

OmarKoueifi commented Feb 5, 2025

Beamanator commented Feb 5, 2025

Beamanator commented Feb 5, 2025

melvin-bot bot commented Feb 5, 2025

Beamanator commented Feb 5, 2025

OSBotify commented Feb 5, 2025

github-actions bot commented Feb 6, 2025

izarutskaya commented Feb 7, 2025

github-actions bot commented Feb 11, 2025

Prevent It's not here message when logging in #55721 #56228

Prevent It's not here message when logging in #55721 #56228

Conversation

OmarKoueifi commented Feb 3, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

github-actions bot commented Feb 3, 2025 • edited Loading

OmarKoueifi commented Feb 3, 2025

OmarKoueifi commented Feb 3, 2025

OmarKoueifi commented Feb 3, 2025

OmarKoueifi commented Feb 3, 2025

melvin-bot bot commented Feb 3, 2025

rushatgabhane Feb 4, 2025 • edited Loading

Choose a reason for hiding this comment

OmarKoueifi Feb 4, 2025

Choose a reason for hiding this comment

rushatgabhane commented Feb 5, 2025

Reviewer Checklist

Screenshots/Videos

New account sign up

not authorized and not logged in

Already logged in and to 404

sign in and authorized

rushatgabhane left a comment

Choose a reason for hiding this comment

Beamanator left a comment

Choose a reason for hiding this comment

Beamanator commented Feb 5, 2025

OmarKoueifi commented Feb 5, 2025

Beamanator commented Feb 5, 2025

Beamanator commented Feb 5, 2025

melvin-bot bot commented Feb 5, 2025

Beamanator commented Feb 5, 2025

OSBotify commented Feb 5, 2025

github-actions bot commented Feb 6, 2025

izarutskaya commented Feb 7, 2025

github-actions bot commented Feb 11, 2025

OmarKoueifi commented Feb 3, 2025 •

edited

Loading

github-actions bot commented Feb 3, 2025 •

edited

Loading

rushatgabhane Feb 4, 2025 •

edited

Loading