[Due for payment 2025-02-19] [$250] Strange next steps message format "Waiting for Your expense(s) to automatically submit on the 5th of each month".

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

**Version Number:**9.0.72-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @jamesdeanexpensify
Slack conversation (hyperlinked to channel name): #expense

Action Performed:

Prerequisite: Delay submission enabled and set to monthly with a date, 5th in this case

1. Submit an expense to a workspace

Expected Result:

Next step displayed as "Waiting for your expense(s) to automatically submit on the 5th of each month"

Actual Result:

Next step displayed as "Waiting for Your expense(s) to automatically submit on the 5th of each month".

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021866438997228157381
• Upwork Job ID: 1866438997228157381
• Last Price Increase: 2024-12-17
• Automatic offers:
• nkdengineer | Contributor | 105414364

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Shahidullah-Muffakir]

Edited by proposal-police: This proposal was edited at 2024-12-09 19:06:44 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Your is shown in bold if the Scheduled submit is enabled

What is the root cause of that problem?

The type is bold here:

App/src/libs/NextStepUtils.ts

Lines 145 to 146 in 0dd36c9

	text: `${ownerDisplayName}`,
	type: 'strong',

What changes do you think we should make in order to solve the problem?

I think we can change it to this:
type: ownerAccountID !== currentUserAccountID ? 'strong' : undefined,

and also change the Your to your here;

App/src/libs/NextStepUtils.ts

Line 50 in f105ac8

content = nextPart?.text === `'s` ? 'Your' : 'You';

and for this issue #53773 (comment):
change this to same like above:
change You to you here:

App/src/libs/NextStepUtils.ts

Line 50 in f105ac8

content = nextPart?.text === `'s` ? 'Your' : 'You';

and change this:

App/src/libs/NextStepUtils.ts

Lines 110 to 133 in 06abff8

	switch (predictedNextStatus) {
	// Generates an optimistic nextStep once a report has been opened
	case CONST.REPORT.STATUS_NUM.OPEN:
	// Self review
	optimisticNextStep = {
	type,
	icon: CONST.NEXT_STEP.ICONS.HOURGLASS,
	message: [
	{
	text: 'Waiting for ',
	},
	{
	text: `${ownerDisplayName}`,
	type: 'strong',
	clickToCopyText: ownerAccountID === currentUserAccountID ? currentUserEmail : '',
	},
	{
	text: ' to ',
	},
	{
	text: 'add',
	},
	{
	text: ' %expenses.',

            message: [
                    {
                        text: 'Waiting for ',
                    },
                    {
                        text: `${ownerDisplayName}`,
                        type: ownerAccountID !== currentUserAccountID ? 'strong' : undefined,
                        clickToCopyText: ownerAccountID === currentUserAccountID ? currentUserEmail : '',
                    },
                    {
                        text: ' to ',
                    },
                    {
                        text: 'add',
                    },
                    {
                        text: ' %expenses',
                    },
                ],

[jamesdeanexpensify]

Just to clarify - we also want it to be lower-case your (instead of Your), thanks!

[nkdengineer]

Edited by proposal-police: This proposal was edited at 2024-12-09 19:04:16 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Next step displayed as "Waiting for Your expense(s) to automatically submit on the 5th of each month".

What is the root cause of that problem?

We have 2 problems here

1. In the function parseMessage we are set with upper-case 'Your' and 'You'

App/src/libs/NextStepUtils.ts

Line 50 in f105ac8

content = nextPart?.text === `'s` ? 'Your' : 'You';

2. And we set type 'strong' for text ownerDisplayName

App/src/libs/NextStepUtils.ts

Line 146 in 0dd36c9

type: 'strong',

What changes do you think we should make in order to solve the problem?

1. We should change this to your and you

            content = nextPart?.text === `'s` ? 'your' : 'you';

App/src/libs/NextStepUtils.ts

Line 50 in f105ac8

content = nextPart?.text === `'s` ? 'Your' : 'You';

2. We can change this type to undefined in case it's 'your'

    type: ownerAccountID !== currentUserAccountID ? 'strong' : undefined,

App/src/libs/NextStepUtils.ts

Line 146 in 0dd36c9

type: 'strong',

3. It looks like BE is still returning type as strong while we have updated type in optimisticNextStep to undefined so we also need to BE fix in this case.

The result after change in offline mode

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Optional: we can remove tagType = 'strong' here

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[jamesdeanexpensify]

Would it also be possible to fix the below as part of this, as well?

• Change You to you and remove the period at the end

[nkdengineer]

updated proposal

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021866438997228157381

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[getusha]

@jamesdeanexpensify do we want to keep the styling bold?

[jamesdeanexpensify]

I think in the your case no, in the you case yes. Does that make sense?

[nkdengineer]

Change You to you and remove the period at the end

@jamesdeanexpensify i see all the next steps have a period at the end. Should we delete it in this case?

[jamesdeanexpensify]

Good shout! Let's keep the period. I was mixing it up with system messages. Thanks!

[melvin-bot]

@garrettmknight, @getusha Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@garrettmknight, @getusha Huh... This is 4 days overdue. Who can take care of this?

[getusha]

@nkdengineer's proposal looks good to me. they were the first one to provide a complete proposal.
🎀 👀 🎀 C+ Reviewed!

[melvin-bot]

Triggered auto assignment to @mjasikowski, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[jamesdeanexpensify]

Sorry - just to confirm, my preference is to not bold your, but still bold whenever a name/email/phone is used. But if that requires too much work, fine to bold it for now!

[melvin-bot]

@garrettmknight, @mjasikowski, @getusha, @nkdengineer 10 days overdue. I'm getting more depressed than Marvin.

[melvin-bot]

@garrettmknight, @mjasikowski, @getusha, @nkdengineer 12 days overdue now... This issue's end is nigh!

[melvin-bot]

This issue has not been updated in over 14 days. @garrettmknight, @mjasikowski, @getusha, @nkdengineer eroding to Weekly issue.

[mjasikowski]

@nkdengineer @getusha friendly bump

[nkdengineer]

thanks @mjasikowski, i'll open PR soon

[jamesdeanexpensify]

Just saw this one pop up again - where at we at with this? Thanks!

[mjasikowski]

@nkdengineer any ETA on the PR?

[nkdengineer]

@mjasikowski we have open PR here and waiting for @getusha review

[melvin-bot]

This issue has not been updated in over 15 days. @garrettmknight, @mjasikowski, @getusha, @nkdengineer eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[jamesdeanexpensify]

I think we can probably move this back to Weekly since the PR is moving along.

[garrettmknight]

Huh, shouldn't have eroded with Reviewing I thought.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.96-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: strange next steps message format #54454

If no regressions arise, payment will be issued on 2025-02-19. 🎊

For reference, here are some details about the assignees on this issue:

• @getusha requires payment through NewDot Manual Requests
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

@getusha @garrettmknight @getusha The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]