Skip to content

Commit

Permalink
Merge pull request #53730 from bernhardoj/fix/53251-skeleton-cut-off-…
Browse files Browse the repository at this point in the history
…when-search-empty

Hide search skeleton empty view scrollbar
  • Loading branch information
deetergp authored Dec 9, 2024
2 parents 0dd36c9 + b052ae9 commit f105ac8
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/components/EmptyStateComponent/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ function EmptyStateComponent({
headerStyles,
headerContentStyles,
lottieWebViewStyles,
showsVerticalScrollIndicator,
minModalHeight = 400,
}: EmptyStateComponentProps) {
const styles = useThemeStyles();
Expand Down Expand Up @@ -83,6 +84,7 @@ function EmptyStateComponent({

return (
<ScrollView
showsVerticalScrollIndicator={showsVerticalScrollIndicator}
contentContainerStyle={[{minHeight: minModalHeight}, styles.flexGrow1, styles.flexShrink0, containerStyles]}
style={styles.flex1}
>
Expand Down
1 change: 1 addition & 0 deletions src/components/EmptyStateComponent/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ type SharedProps<T> = {
headerContentStyles?: StyleProp<ViewStyle & ImageStyle>;
lottieWebViewStyles?: React.CSSProperties | undefined;
minModalHeight?: number;
showsVerticalScrollIndicator?: boolean;
};

type MediaType<HeaderMedia, T extends MediaTypes> = SharedProps<T> & {
Expand Down
1 change: 1 addition & 0 deletions src/pages/Search/EmptySearchView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,7 @@ function EmptySearchView({type, hasResults}: EmptySearchViewProps) {
<>
<EmptyStateComponent
SkeletonComponent={SearchRowSkeleton}
showsVerticalScrollIndicator={false}
headerMediaType={CONST.EMPTY_STATE_MEDIA.ANIMATION}
headerMedia={content.headerMedia}
headerStyles={[styles.emptyStateCardIllustrationContainer, styles.overflowHidden]}
Expand Down

0 comments on commit f105ac8

Please sign in to comment.