fix lint and apply suggestions

src/components/InitialURLContextProvider.tsx

@@ -2,7 +2,7 @@ import React, {createContext, useEffect, useMemo, useState} from 'react';
 import type {ReactNode} from 'react';
 import {Linking} from 'react-native';
 import {signInAfterTransitionFromOldDot} from '@libs/actions/Session';
-import {AppProps} from '@src/App';
+import type {AppProps} from '@src/App';
 import CONST from '@src/CONST';
 import type {Route} from '@src/ROUTES';
 import {useSplashScreenStateContext} from '@src/SplashScreenStateContext';
@@ -41,6 +41,8 @@ function InitialURLContextProvider({children, url, hybridAppSettings, timestamp}
         Linking.getInitialURL().then((initURL) => {
             setInitialURL(initURL as Route);
         });
+        // Rules are disabled because changes to splashScreenState could trigger code
+        // that should only execute when new props (url, hybridAppSettings, timestamp) are passed.
         // eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
     }, [url, hybridAppSettings, timestamp]);
 

src/libs/actions/Welcome/index.ts

@@ -11,7 +11,7 @@ import type {OnboardingPurpose} from '@src/types/onyx';
 import type Onboarding from '@src/types/onyx/Onboarding';
 import type TryNewDot from '@src/types/onyx/TryNewDot';
 import {isEmptyObject} from '@src/types/utils/EmptyObject';
-import * as OnboardingFlow from './OnboardingFlow';
+import {clearInitialPath} from './OnboardingFlow';
 
 type OnboardingData = Onboarding | undefined;
 
@@ -183,7 +183,7 @@ function resetAllChecks() {
     });
     isLoadingReportData = true;
     isOnboardingInProgress = false;
-    OnboardingFlow.clearInitialPath();
+    clearInitialPath();
 }
 
 function setSelfTourViewed(shouldUpdateOnyxDataOnlyLocally = false) {

src/pages/ErrorPage/SessionExpiredPage.tsx

@@ -9,7 +9,7 @@ import useLocalize from '@hooks/useLocalize';
 import useTheme from '@hooks/useTheme';
 import useThemeStyles from '@hooks/useThemeStyles';
 import Navigation from '@libs/Navigation/Navigation';
-import * as Session from '@userActions/Session';
+import {clearSignInData} from '@userActions/Session';
 
 function SessionExpiredPage() {
     const styles = useThemeStyles();
@@ -33,7 +33,7 @@ function SessionExpiredPage() {
                         <TextLink
                             onPress={() => {
                                 if (!NativeModules.HybridAppModule) {
-                                    Session.clearSignInData();
+                                    clearSignInData();
                                     Navigation.goBack();
                                     return;
                                 }