Skip to content

Commit

Permalink
remove duplicate UpdateAutoReportingFrequency translation utils.
Browse files Browse the repository at this point in the history
Signed-off-by: krishna2323 <[email protected]>
  • Loading branch information
Krishna2323 committed Feb 12, 2025
1 parent 800e490 commit 3dafa17
Show file tree
Hide file tree
Showing 7 changed files with 0 additions and 41 deletions.
3 changes: 0 additions & 3 deletions src/languages/en.ts
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,6 @@ import type {
UpdatedPolicyTagFieldParams,
UpdatedPolicyTagNameParams,
UpdatedPolicyTagParams,
UpdateAutoReportingFrequencyParams,
UpdatedTheDistanceMerchantParams,
UpdatedTheRequestParams,
UpdateRoleParams,
Expand Down Expand Up @@ -5148,8 +5147,6 @@ const translations = {
leftWorkspace: ({nameOrEmail}: LeftWorkspaceParams) => `${nameOrEmail} left the workspace`,
removeMember: ({email, role}: AddEmployeeParams) => `removed ${role === 'member' || role === 'user' ? 'member' : 'admin'} ${email}`,
removedConnection: ({connectionName}: ConnectionNameParams) => `removed connection to ${CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}`,
updateAutoReportingFrequency: ({oldFrequency, newFrequency}: UpdateAutoReportingFrequencyParams) =>
`updated the submission frequency to "${newFrequency}" (previously "${oldFrequency}")`,
},
},
},
Expand Down
3 changes: 0 additions & 3 deletions src/languages/es.ts
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,6 @@ import type {
UpdatedPolicyTagFieldParams,
UpdatedPolicyTagNameParams,
UpdatedPolicyTagParams,
UpdateAutoReportingFrequencyParams,
UpdatedTheDistanceMerchantParams,
UpdatedTheRequestParams,
UpdateRoleParams,
Expand Down Expand Up @@ -5203,8 +5202,6 @@ const translations = {
leftWorkspace: ({nameOrEmail}: LeftWorkspaceParams) => `${nameOrEmail} salió del espacio de trabajo`,
removeMember: ({email, role}: AddEmployeeParams) => `eliminado ${role === 'miembro' || role === 'user' ? 'miembro' : 'administrador'} ${email}`,
removedConnection: ({connectionName}: ConnectionNameParams) => `eliminó la conexión a ${CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}`,
updateAutoReportingFrequency: ({oldFrequency, newFrequency}: UpdateAutoReportingFrequencyParams) =>
`actualizó la frecuencia de envíos a "${newFrequency}" (previamente "${oldFrequency}")`,
},
},
},
Expand Down
6 changes: 0 additions & 6 deletions src/languages/params.ts
Original file line number Diff line number Diff line change
Expand Up @@ -377,11 +377,6 @@ type ConnectionNameParams = {
connectionName: AllConnectionName;
};

type UpdateAutoReportingFrequencyParams = {
oldFrequency: string;
newFrequency: string;
};

type LastSyncDateParams = {
connectionName: string;
formattedDate: string;
Expand Down Expand Up @@ -843,7 +838,6 @@ export type {
UpdateRoleParams,
LeftWorkspaceParams,
RemoveMemberParams,
UpdateAutoReportingFrequencyParams,
DateParams,
FiltersAmountBetweenParams,
StatementPageTitleParams,
Expand Down
17 changes: 0 additions & 17 deletions src/libs/ReportActionsUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2071,22 +2071,6 @@ function getPolicyChangeLogDeleteMemberMessage(reportAction: OnyxInputOrEntry<Re
return translateLocal('report.actions.type.removeMember', {email, role});
}

function isPolicyChangeLogUpdateAutoReportingFrequencyMessage(
reportAction: OnyxInputOrEntry<ReportAction>,
): reportAction is ReportAction<typeof CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_AUTO_REPORTING_FREQUENCY> {
return isActionOfType(reportAction, CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_AUTO_REPORTING_FREQUENCY);
}

function getPolicyChangeLogUpdateAutoReportingFrequencyMessage(reportAction: OnyxInputOrEntry<ReportAction>): string {
if (!isPolicyChangeLogUpdateAutoReportingFrequencyMessage(reportAction)) {
return '';
}
const originalMessage = getOriginalMessage(reportAction);
const oldFrequency = translateLocal(`workspace.common.frequency.${originalMessage?.oldFrequency}` as TranslationPaths);
const newFrequency = translateLocal(`workspace.common.frequency.${originalMessage?.newFrequency}` as TranslationPaths);
return translateLocal('report.actions.type.updateAutoReportingFrequency', {oldFrequency, newFrequency});
}

function getRemovedConnectionMessage(reportAction: OnyxEntry<ReportAction>): string {
if (!isActionOfType(reportAction, CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.DELETE_INTEGRATION)) {
return '';
Expand Down Expand Up @@ -2320,7 +2304,6 @@ export {
getPolicyChangeLogAddEmployeeMessage,
getPolicyChangeLogChangeRoleMessage,
getPolicyChangeLogDeleteMemberMessage,
getPolicyChangeLogUpdateAutoReportingFrequencyMessage,
getPolicyChangeLogEmployeeLeftMessage,
getRenamedAction,
isCardIssuedAction,
Expand Down
3 changes: 0 additions & 3 deletions src/pages/home/report/ContextMenu/ContextMenuActions.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ import {
getPolicyChangeLogDeleteMemberMessage,
getPolicyChangeLogMaxExpenseAmountMessage,
getPolicyChangeLogMaxExpesnseAmountNoReceiptMessage,
getPolicyChangeLogUpdateAutoReportingFrequencyMessage,
getRemovedConnectionMessage,
getRenamedAction,
getReportActionMessageText,
Expand Down Expand Up @@ -594,8 +593,6 @@ const ContextMenuActions: ContextMenuAction[] = [
setClipboardMessage(getPolicyChangeLogChangeRoleMessage(reportAction));
} else if (reportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.DELETE_EMPLOYEE) {
setClipboardMessage(getPolicyChangeLogDeleteMemberMessage(reportAction));
} else if (reportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_AUTO_REPORTING_FREQUENCY) {
setClipboardMessage(getPolicyChangeLogUpdateAutoReportingFrequencyMessage(reportAction));
} else if (reportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.DELETED_TRANSACTION) {
setClipboardMessage(getDeletedTransactionMessage(reportAction));
} else if (isActionOfType(reportAction, CONST.REPORT.ACTIONS.TYPE.INTEGRATION_SYNC_FAILED)) {
Expand Down
3 changes: 0 additions & 3 deletions src/pages/home/report/PureReportActionItem.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ import {
getPolicyChangeLogDeleteMemberMessage,
getPolicyChangeLogMaxExpenseAmountMessage,
getPolicyChangeLogMaxExpesnseAmountNoReceiptMessage,
getPolicyChangeLogUpdateAutoReportingFrequencyMessage,
getRemovedConnectionMessage,
getRemovedFromApprovalChainMessage,
getRenamedAction,
Expand Down Expand Up @@ -923,8 +922,6 @@ function PureReportActionItem({
children = <ReportActionItemBasicMessage message={getPolicyChangeLogChangeRoleMessage(action)} />;
} else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.DELETE_EMPLOYEE) {
children = <ReportActionItemBasicMessage message={getPolicyChangeLogDeleteMemberMessage(action)} />;
} else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_AUTO_REPORTING_FREQUENCY) {
children = <ReportActionItemBasicMessage message={getPolicyChangeLogUpdateAutoReportingFrequencyMessage(action)} />;
} else if (isActionOfType(action, CONST.REPORT.ACTIONS.TYPE.REMOVED_FROM_APPROVAL_CHAIN)) {
children = <ReportActionItemBasicMessage message={getRemovedFromApprovalChainMessage(action)} />;
} else if (
Expand Down
6 changes: 0 additions & 6 deletions src/types/onyx/OriginalMessage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -398,12 +398,6 @@ type OriginalMessagePolicyChangeLog = {

/** Old role of user or old value of the category/tag field */
oldValue?: boolean | string;

/** Old auto-reporting frequency */
oldFrequency?: string;

/** New auto-reporting frequency */
newFrequency?: string;
};

/** Model of `join policy changelog` report action */
Expand Down

0 comments on commit 3dafa17

Please sign in to comment.