Merge pull request #55636 from ishakakkad/55433-search-filter-clear-fix

Removing one value from Search filter clears the search
Expensify · Jan 23, 2025 · 136b291 · 136b291
2 parents 2550438 + 82c5532
commit 136b291
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/src/components/Search/SearchPageHeaderInput.tsx b/src/components/Search/SearchPageHeaderInput.tsx
@@ -124,7 +124,7 @@ function SearchPageHeaderInput({queryJSON, children}: SearchPageHeaderInputProps
             const updatedSubstitutionsMap = getUpdatedSubstitutionsMap(userQuery, autocompleteSubstitutions);
             setAutocompleteSubstitutions(updatedSubstitutionsMap);
 
-            if (updatedUserQuery || textInputValue.length > 0) {
+            if (updatedUserQuery) {
                 listRef.current?.updateAndScrollToFocusedIndex(0);
             } else {
                 listRef.current?.updateAndScrollToFocusedIndex(-1);
@@ -148,9 +148,12 @@ function SearchPageHeaderInput({queryJSON, children}: SearchPageHeaderInputProps
                 setTextInputValue('');
                 setAutocompleteQueryValue('');
                 setIsAutocompleteListVisible(false);
+            } else {
+                setTextInputValue(queryText);
+                setAutocompleteQueryValue(queryText);
             }
         },
-        [autocompleteSubstitutions, originalInputQuery, queryJSON.policyID],
+        [autocompleteSubstitutions, originalInputQuery, queryJSON.policyID, queryText],
     );
 
     const onListItemPress = useCallback(
@@ -260,6 +263,10 @@ function SearchPageHeaderInput({queryJSON, children}: SearchPageHeaderInputProps
                     onSearchQueryChange={onSearchQueryChange}
                     isFullWidth
                     onSubmit={() => {
+                        const focusedOption = listRef.current?.getFocusedOption();
+                        if (focusedOption) {
+                            return;
+                        }
                         submitSearch(textInputValue);
                     }}
                     autoFocus={false}