[WIP] Xmp toolkit v2023-12 submodule #3014
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request attempts to pull
XMP-Toolkit-SDKas a submodule. Due to the complicated and messy build system inXMP-Toolkit-SDK, I avoid using it and instead use the existing in-tree build system with some modifications.I have made several hacky workarounds:
/third-party/expat/lib/expat.hinXMP-Toolkit-SDK. Since we pullexpatas an external dependency, I had to copyexpat.hto a fakethird-party/expat/lib/directory in the build folder at generation time. I am not quite sure if the same will be possible withmeson.MD5Updatehas a slightly different signature, so I used aconst_cast. I expect to get rid of this when I do a refactoring.SXMPMeta::DeleteNamespaceseems to be deprecated in this version, which needs further investigation.To-do:
XMP-Toolkit-SDKrequires, e.g.,WIN_ENV,WIN_UNIVERSAL_ENV, etc.meson.xmp.cppand all associated files.