fix: prevent crash when encoding payload with invalid UTF-8 #323
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR wraps
vim.fn.json_encode()in apcall()to avoid crashing when Codeium tries to encode invalid UTF-8 payloads.Problem
Some buffers (e.g., minified
.mjs,.sum, or binary-like files) contain invalid UTF-8. Codeium tries to encode the completion request payload withvim.fn.json_encode, leading to:Vim:E474: String contains byte that does not start any UTF-8 character
Fix
pcall.Tested locally with such files, and Codeium no longer crashes.
Fixes a class of bugs seen when using preview panels or telescope buffers as well.