Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade the SDK version to 17.5.33428.388 #30

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

thedemons
Copy link
Contributor

@thedemons thedemons commented Dec 14, 2023

Opting for the latest SDK version inadvertently limited the versions of assemblies we could use. Initially, I assumed that the extension could reference any assemblies with the same name, similar to the behavior in C++. However, I discovered that there is a specific version requirement for referencing assemblies.

The required assemblies for SDK v17.5.33428.388 can be viewed here.

Some of the downsides of this are:

  • The inline diff adornment can't check if there was a peek session that overlaps it anymore because InterLineAdornmentTag only exists in 17.8.37222 and above. It will now close any peek sessions that are in the same text view.
  • We must use some ugly reflections in the proposals, because SuggestionAcceptedEventArgs only exists in SDK >=17.6.36389, potentially rendering the OnSuggestionAccepted useless in VS <17.6
  • Had to suppress deprecated warnings in the proposal classes.

The inability to install earlier versions of VS continues to pose challenges for development and testing.

@fortenforge
Copy link
Collaborator

How did you discover this?

@fortenforge fortenforge merged commit 76e0436 into Exafunction:main Dec 15, 2023
1 check passed
@thedemons
Copy link
Contributor Author

From a user bug report Visual Studio 2022 (17.7.7) Chat isn't working, and how to know, that the rest should work.

It says "Microsoft.VisualStudio.Threading.17.8.0.0 is missing." in their activity log, and I saw that in the dependencies of the SDK, it says Microsoft.VisualStudio.Threading >= 17.8.14.

@thedemons thedemons deleted the downgrade-sdk branch December 15, 2023 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants